From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIECK-0006kd-Te for qemu-devel@nongnu.org; Mon, 02 Feb 2015 05:25:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIECG-0006HV-Lb for qemu-devel@nongnu.org; Mon, 02 Feb 2015 05:25:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33522) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIECG-0006HO-8R for qemu-devel@nongnu.org; Mon, 02 Feb 2015 05:25:36 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t12APZJj022434 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 2 Feb 2015 05:25:35 -0500 Message-ID: <54CF509A.2010408@redhat.com> Date: Mon, 02 Feb 2015 11:25:30 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1422643333-27926-1-git-send-email-jsnow@redhat.com> <1422643333-27926-5-git-send-email-jsnow@redhat.com> In-Reply-To: <1422643333-27926-5-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/19] libqos/ahci: Add command header helpers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: famz@redhat.com, armbru@redhat.com, stefanha@redhat.com, mst@redhat.com On 30/01/2015 19:41, John Snow wrote: > + /* Construct our Command Header (set_command_header handles endianness.) */ > + memset(&cmd, 0x00, sizeof(cmd)); > + cmd.flags = 5; /* reg_h2d_fis is 5 double-words long */ > + cmd.flags = 0x400; /* clear PxTFD.STS.BSY when done */ And here |= became = ? Paolo > + cmd.prdtl = 1; /* One PRD table entry. */