From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIEKb-0003Qp-67 for qemu-devel@nongnu.org; Mon, 02 Feb 2015 05:34:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIEKa-0000Qi-EK for qemu-devel@nongnu.org; Mon, 02 Feb 2015 05:34:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIEKa-0000QV-75 for qemu-devel@nongnu.org; Mon, 02 Feb 2015 05:34:12 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t12AYBIF018931 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 2 Feb 2015 05:34:11 -0500 Message-ID: <54CF529E.7050809@redhat.com> Date: Mon, 02 Feb 2015 11:34:06 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1422643333-27926-1-git-send-email-jsnow@redhat.com> <1422643333-27926-11-git-send-email-jsnow@redhat.com> In-Reply-To: <1422643333-27926-11-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/19] libqos/ahci: Add ide cmd properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: famz@redhat.com, armbru@redhat.com, stefanha@redhat.com, mst@redhat.com On 30/01/2015 19:42, John Snow wrote: > The "Invalid Command Sentinel" here that caps the property array is an > invalid ATA command, namely 0x01. 0x00 is NOP and 0xFF is reserved for > vendor usage, so I chose the first invalid one instead. You can use ARRAY_SIZE instead. Paolo