From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIEP1-0006Nn-SB for qemu-devel@nongnu.org; Mon, 02 Feb 2015 05:38:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIEOy-0001sk-Gr for qemu-devel@nongnu.org; Mon, 02 Feb 2015 05:38:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50724) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIEOy-0001se-9u for qemu-devel@nongnu.org; Mon, 02 Feb 2015 05:38:44 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t12AchLx000825 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 2 Feb 2015 05:38:43 -0500 Message-ID: <54CF53AE.3000704@redhat.com> Date: Mon, 02 Feb 2015 11:38:38 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1422643333-27926-1-git-send-email-jsnow@redhat.com> <1422643333-27926-20-git-send-email-jsnow@redhat.com> In-Reply-To: <1422643333-27926-20-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 19/19] qtest/ahci: Adding simple dma read-write test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: famz@redhat.com, armbru@redhat.com, stefanha@redhat.com, mst@redhat.com On 30/01/2015 19:42, John Snow wrote: > + memwrite(ptr, tx, bufsize); > + > + /* Write this buffer to disk, then read it back to the DMA buffer. */ > + ahci_guest_io(ahci, px, CMD_WRITE_DMA, ptr, bufsize); I would qmemset the buffer here. Paolo > + ahci_guest_io(ahci, px, CMD_READ_DMA, ptr, bufsize); > + > + /*** Read back the Data ***/ > + memread(ptr, rx, bufsize); > + g_assert_cmphex(memcmp(tx, rx, bufsize), ==, 0);