From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIEPL-0006se-Cg for qemu-devel@nongnu.org; Mon, 02 Feb 2015 05:39:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIEPI-0001vx-5M for qemu-devel@nongnu.org; Mon, 02 Feb 2015 05:39:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIEPH-0001vt-Tn for qemu-devel@nongnu.org; Mon, 02 Feb 2015 05:39:04 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t12Ad39G027450 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 2 Feb 2015 05:39:03 -0500 Message-ID: <54CF53C2.3000003@redhat.com> Date: Mon, 02 Feb 2015 11:38:58 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1422643333-27926-1-git-send-email-jsnow@redhat.com> In-Reply-To: <1422643333-27926-1-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/19] qtest/ahci: add dma test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: famz@redhat.com, armbru@redhat.com, stefanha@redhat.com, mst@redhat.com On 30/01/2015 19:41, John Snow wrote: > Add a simple DMA r/w test to ahci-test. > > Oh, and for the first 18 patches, refactor everything into helpers so > that each ahci_test isn't a thousand lines long. > > This patch depends upon the "ahci test preliminary refactoring" series > upstream, which shuffled a lot of libqos and malloc facilities to > support this series. > > This patchset is a necessary step in checking in AHCI/DMA migration > tests that I will later use as proof as suitability of enabling the > ICH9 and AHCI migration flags. Sent a few comments, everything that I didn't reply to has my Reviewed-by. Paolo > John Snow (19): > libqos/ahci: Add ahci_port_select helper > libqos/ahci: Add ahci_port_clear helper > qtest/ahci: rename 'Command' to 'CommandHeader' > libqos/ahci: Add command header helpers > libqos/ahci: Add ahci_port_check_error helper > libqos/ahci: Add ahci_port_check_interrupts helper > libqos/ahci: Add port_check_nonbusy helper > libqos/ahci: Add cmd response sanity check helpers > qtest/ahci: Demagic ahci tests. > libqos/ahci: Add ide cmd properties > libqos/ahci: add ahci command functions > libqos/ahci: add ahci command verify > libqos/ahci: add ahci command size setters > libqos/ahci: Add ahci_guest_io > libqos/ahci: add ahci_io > libqos/ahci: Add ahci_clean_mem > qtest/ahci: Add a macro bootup routine > qtest/ahci: Assert sector size in identify test > qtest/ahci: Adding simple dma read-write test > > tests/ahci-test.c | 246 +++++++++------------- > tests/libqos/ahci.c | 554 ++++++++++++++++++++++++++++++++++++++++++++++++++ > tests/libqos/ahci.h | 163 ++++++++++++--- > tests/libqos/malloc.c | 5 + > tests/libqos/malloc.h | 1 + > 5 files changed, 798 insertions(+), 171 deletions(-) >