From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIKAI-0000JY-05 for qemu-devel@nongnu.org; Mon, 02 Feb 2015 11:47:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIKAF-0000xv-AD for qemu-devel@nongnu.org; Mon, 02 Feb 2015 11:47:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38967) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIKAF-0000xi-2r for qemu-devel@nongnu.org; Mon, 02 Feb 2015 11:47:55 -0500 Message-ID: <54CFAA35.4030805@redhat.com> Date: Mon, 02 Feb 2015 17:47:49 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1422895464-18038-1-git-send-email-den@openvz.org> <1422895464-18038-2-git-send-email-den@openvz.org> In-Reply-To: <1422895464-18038-2-git-send-email-den@openvz.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/1] block: align bounce buffers to page List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi On 02/02/2015 17:44, Denis V. Lunev wrote: > +++ b/block/raw-posix.c > @@ -667,7 +667,8 @@ static void raw_refresh_limits(BlockDriverState *bs, Error **errp) > BDRVRawState *s = bs->opaque; > > raw_probe_alignment(bs, s->fd, errp); > - bs->bl.opt_mem_alignment = s->buf_align; > + bs->bl.min_mem_alignment = s->buf_align; > + bs->bl.opt_mem_alignment = MAX(sysconf(_SC_PAGESIZE), s->buf_align); This does not exist on Windows. You have to use getpagesize(), for which there is a wrapper in util/oslib-win32.c. Paolo > raw_probe_max_write_zeroes(bs);