From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40307)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1YIKBt-0001gk-1B
	for qemu-devel@nongnu.org; Mon, 02 Feb 2015 11:49:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1YIKBq-0001Op-8s
	for qemu-devel@nongnu.org; Mon, 02 Feb 2015 11:49:36 -0500
Received: from mx2.parallels.com ([199.115.105.18]:40998)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1YIKBq-0001Oj-3P
	for qemu-devel@nongnu.org; Mon, 02 Feb 2015 11:49:34 -0500
Message-ID: <54CFAA96.4000708@openvz.org>
Date: Mon, 2 Feb 2015 19:49:26 +0300
From: "Denis V. Lunev" <den@openvz.org>
MIME-Version: 1.0
References: <1422895464-18038-1-git-send-email-den@openvz.org>
	<1422895464-18038-2-git-send-email-den@openvz.org>
	<54CFAA35.4030805@redhat.com>
In-Reply-To: <54CFAA35.4030805@redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/1] block: align bounce buffers to page
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On 02/02/15 19:47, Paolo Bonzini wrote:
>
> On 02/02/2015 17:44, Denis V. Lunev wrote:
>> +++ b/block/raw-posix.c
>> @@ -667,7 +667,8 @@ static void raw_refresh_limits(BlockDriverState *bs, Error **errp)
>>       BDRVRawState *s = bs->opaque;
>>   
>>       raw_probe_alignment(bs, s->fd, errp);
>> -    bs->bl.opt_mem_alignment = s->buf_align;
>> +    bs->bl.min_mem_alignment = s->buf_align;
>> +    bs->bl.opt_mem_alignment = MAX(sysconf(_SC_PAGESIZE), s->buf_align);
> This does not exist on Windows.  You have to use getpagesize(), for
> which there is a wrapper in util/oslib-win32.c.
>
> Paolo
>
>>       raw_probe_max_write_zeroes(bs);
cool suggestion, will do that. Thank you