From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YILB6-0002i2-CF for qemu-devel@nongnu.org; Mon, 02 Feb 2015 12:52:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YILB3-0004cv-4O for qemu-devel@nongnu.org; Mon, 02 Feb 2015 12:52:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36090) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YILB2-0004ce-TK for qemu-devel@nongnu.org; Mon, 02 Feb 2015 12:52:49 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t12Hql5O031163 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 2 Feb 2015 12:52:48 -0500 Message-ID: <54CFB96E.7090903@redhat.com> Date: Mon, 02 Feb 2015 12:52:46 -0500 From: Max Reitz MIME-Version: 1.0 References: <1422524221-8566-1-git-send-email-armbru@redhat.com> In-Reply-To: <1422524221-8566-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/4] block: Cleanups around error reporting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com On 2015-01-29 at 04:36, Markus Armbruster wrote: > v2: > * PATCH 4: Use error_setg() [Kevin] > * R-bys retained > > Markus Armbruster (4): > blockdev: Give find_block_job() an Error ** parameter > blockdev: Eliminate silly QERR_BLOCK_JOB_NOT_ACTIVE macro > block: New bdrv_add_key(), convert monitor to use it > block: Eliminate silly QERR_ macros used for encryption keys > > block.c | 30 ++++++++++++++++++++++++++++++ > blockdev.c | 44 +++++++++++--------------------------------- > include/block/block.h | 1 + > include/qapi/qmp/qerror.h | 9 --------- > monitor.c | 16 +++++++++++----- > qmp.c | 8 ++++---- > 6 files changed, 57 insertions(+), 51 deletions(-) Thanks, applied to my block tree: https://github.com/XanClic/qemu/commits/block