From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46236)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1YIOT1-0003Ho-TK
	for qemu-devel@nongnu.org; Mon, 02 Feb 2015 16:23:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1YIOSw-00067g-Ko
	for qemu-devel@nongnu.org; Mon, 02 Feb 2015 16:23:35 -0500
Received: from mx1.redhat.com ([209.132.183.28]:53290)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1YIOSw-00067c-Cv
	for qemu-devel@nongnu.org; Mon, 02 Feb 2015 16:23:30 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t12LNTcB013111
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Mon, 2 Feb 2015 16:23:29 -0500
Message-ID: <54CFDF2C.3000900@redhat.com>
Date: Mon, 02 Feb 2015 15:33:48 -0500
From: John Snow <jsnow@redhat.com>
MIME-Version: 1.0
References: <1422643333-27926-1-git-send-email-jsnow@redhat.com>	<1422643333-27926-5-git-send-email-jsnow@redhat.com>
	<54CF509A.2010408@redhat.com>
In-Reply-To: <54CF509A.2010408@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 04/19] libqos/ahci: Add command header
	helpers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: famz@redhat.com, armbru@redhat.com, stefanha@redhat.com, mst@redhat.com



On 02/02/2015 05:25 AM, Paolo Bonzini wrote:
>
>
> On 30/01/2015 19:41, John Snow wrote:
>> +    /* Construct our Command Header (set_command_header handles endianness.) */
>> +    memset(&cmd, 0x00, sizeof(cmd));
>> +    cmd.flags = 5;     /* reg_h2d_fis is 5 double-words long */
>> +    cmd.flags = 0x400; /* clear PxTFD.STS.BSY when done */
>
> And here |= became = ?
>
> Paolo
>
>> +    cmd.prdtl = 1;     /* One PRD table entry. */
>

A typo that testing didn't pick up on. (I wonder how?)
Thank you.