From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIRvR-0001YE-T8 for qemu-devel@nongnu.org; Mon, 02 Feb 2015 20:05:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIRvO-0006dt-Nm for qemu-devel@nongnu.org; Mon, 02 Feb 2015 20:05:09 -0500 Received: from mga14.intel.com ([192.55.52.115]:14557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIRvO-0006Z1-0e for qemu-devel@nongnu.org; Mon, 02 Feb 2015 20:05:06 -0500 Message-ID: <54D01EAB.1020005@intel.com> Date: Tue, 03 Feb 2015 09:04:43 +0800 From: "Chen, Tiejun" MIME-Version: 1.0 References: <1422839843-25622-1-git-send-email-tiejun.chen@intel.com> <20150202121940.GA28773@zion.uk.xensource.com> <21711.29549.892862.333392@mariner.uk.xensource.com> In-Reply-To: <21711.29549.892862.333392@mariner.uk.xensource.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Jackson , Wei Liu Cc: qemu-devel@nongnu.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, ian.campbell@citrix.com, kraxel@redhat.com On 2015/2/2 20:54, Ian Jackson wrote: > Wei Liu writes ("Re: [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough"): >> On Mon, Feb 02, 2015 at 09:17:23AM +0800, Tiejun Chen wrote: >>> When we're working to support IGD GFX passthrough with qemu >>> upstream, instead of "-gfx_passthru" we'd like to make that >>> a machine option, "-machine xxx,-igd-passthru=on". This need >>> to bring a change on tool side. > ... >> My suggestion has one premise -- if upstream QEMU has already released >> that -gfx_passthru option. If there is no "old one" (in upstream QEMU) >> at all, then there is nothing to keep and deprecate. > > I think the commit message of the xen.git commit should explain what > options are supported by which versions of qemu (including qemu > upstream's future plans). > > That would provide (a) something which summarises the communication > etc. with qemu upstream and can be checked with them if necessary and > (b) something against which the libxl changes can be easily judged. > Sorry, looks I'm misleading this to everyone. Here I picked my reply from another email: Actually qemu upstream never own this option, '-gfx_passthru' at all. This just exists alone in qemu-xen-traditional. So here I'm trying to introduce a new stuff that doesn't clash anything in qemu upstream. So I guess I should rephrase this as follows: libxl: add one machine property to support IGD GFX passthrough When we're working to support IGD GFX passthrough with qemu upstream, we'd like to introduce a machine option, "-machine xxx,igd-passthru=on", to enable/disable that feature. And we also remove that old option, "-gfx_passthru", just from the case of LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN since actually no any qemu stream version really need or use that. So is it good? Thanks Tiejun