From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIZEo-0006do-Lh for qemu-devel@nongnu.org; Tue, 03 Feb 2015 03:53:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIZEl-0006bv-HB for qemu-devel@nongnu.org; Tue, 03 Feb 2015 03:53:38 -0500 Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:54879) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIZEl-0006bh-AQ for qemu-devel@nongnu.org; Tue, 03 Feb 2015 03:53:35 -0500 Received: by mail-wi0-f174.google.com with SMTP id n3so22522035wiv.1 for ; Tue, 03 Feb 2015 00:53:34 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54D08C8A.2090502@redhat.com> Date: Tue, 03 Feb 2015 09:53:30 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1422643333-27926-1-git-send-email-jsnow@redhat.com> <1422643333-27926-18-git-send-email-jsnow@redhat.com> <54CF5380.5080208@redhat.com> <54CFE82A.1040907@redhat.com> In-Reply-To: <54CFE82A.1040907@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 17/19] qtest/ahci: Add a macro bootup routine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: famz@redhat.com, armbru@redhat.com, stefanha@redhat.com, mst@redhat.com On 02/02/2015 22:12, John Snow wrote: > > It comes in handy later for testing migration so I don't have to do a > lot of boilerplate for each instance, though it is just a convenience > subroutine with no logic of its own. > > I like to cut down on boilerplate as much as possible to expose the > logic of the test as much as possible. > > Have a suggestion for a better name, or are you very adamant about > culling it? I'm adamant about culling it because I don't have a suggestion for a better name. In the long run, I think we should just have a qos_boot function that does everything including PCI scanning, mapping BARs and initializing devices. But we're of course very far from that. Paolo