From: Sebastian Macke <sebastian@macke.de>
To: Peter Maydell <peter.maydell@linaro.org>, Jia Liu <proljc@gmail.com>
Cc: blue@cmd.nu, QEMU Developers <qemu-devel@nongnu.org>,
Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PULL 0/2] OpenRISC patch queue for 2.3
Date: Tue, 03 Feb 2015 14:04:56 +0100 [thread overview]
Message-ID: <54D0C778.8020700@macke.de> (raw)
In-Reply-To: <CAFEAcA_x9yvXVKaqpAXcN7yv1BXBqs_KipKyT0kZDhOtPwpzxg@mail.gmail.com>
Hi Peter,
unfortunately you are right.
The correct line is this:
/* invalidate lock */
- env->cpu_lock_addr = -1;
+ env->lock_addr = -1;
I am sorry. It was most likely the last line which I added. But I
forgot, that I disabled the system emulation already.
Therefore my make process didn't complain.
Should I send an updated patch, or can you do a hot-fix?
Sebastian
On 2/3/2015 11:40 AM, Peter Maydell wrote:
> On 3 February 2015 at 02:19, Jia Liu <proljc@gmail.com> wrote:
>> Hi Anthony,
>>
>> This is my OpenRISC patch queue for 2.3, it have been well tested, please pull.
> ...it can't have been very well tested, because it doesn't
> compile:
>
> target-openrisc/interrupt.c: In function ‘openrisc_cpu_do_interrupt’:
> target-openrisc/interrupt.c:58:8: error: ‘CPUOpenRISCState’ has no
> member named ‘cpu_lock_addr’
>
> thanks
> -- PMM
next prev parent reply other threads:[~2015-02-03 13:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 2:19 [Qemu-devel] [PULL 0/2] OpenRISC patch queue for 2.3 Jia Liu
2015-02-03 2:19 ` [Qemu-devel] [PULL 1/2] target-openrisc: Separate of load/store instructions Jia Liu
2015-02-03 2:19 ` [Qemu-devel] [PULL 2/2] target-openrisc: Add l.lwa/l.swa support Jia Liu
2015-02-03 10:40 ` [Qemu-devel] [PULL 0/2] OpenRISC patch queue for 2.3 Peter Maydell
2015-02-03 13:04 ` Sebastian Macke [this message]
2015-02-03 13:07 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D0C778.8020700@macke.de \
--to=sebastian@macke.de \
--cc=aliguori@amazon.com \
--cc=blue@cmd.nu \
--cc=peter.maydell@linaro.org \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).