From: "Andreas Färber" <afaerber@suse.de>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] target-i386: Eliminate unnecessary get_cpuid_vendor() function
Date: Tue, 03 Feb 2015 19:18:03 +0100 [thread overview]
Message-ID: <54D110DB.9030002@suse.de> (raw)
In-Reply-To: <1422986938-13469-3-git-send-email-ehabkost@redhat.com>
Am 03.02.2015 um 19:08 schrieb Eduardo Habkost:
> The function was used in only two places. In one of them, the function
> made the code less readable by requiring temporary te[bcd]x variables.
> In the other one we can simply inline the existing code.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-02-03 18:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 18:08 [Qemu-devel] [PATCH 0/2] target-i386: Small code cleanup Eduardo Habkost
2015-02-03 18:08 ` [Qemu-devel] [PATCH 1/2] target-i386: Simplify listflags() function Eduardo Habkost
2015-02-06 16:02 ` Paolo Bonzini
2015-02-03 18:08 ` [Qemu-devel] [PATCH 2/2] target-i386: Eliminate unnecessary get_cpuid_vendor() function Eduardo Habkost
2015-02-03 18:18 ` Andreas Färber [this message]
2015-03-04 12:28 ` [Qemu-devel] [PATCH 0/2] target-i386: Small code cleanup Eduardo Habkost
2015-03-04 14:05 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D110DB.9030002@suse.de \
--to=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).