From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIjyY-0006nc-Sc for qemu-devel@nongnu.org; Tue, 03 Feb 2015 15:21:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIjyT-0004p5-UO for qemu-devel@nongnu.org; Tue, 03 Feb 2015 15:21:34 -0500 Received: from mout.web.de ([212.227.15.4]:55308) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIjyT-0004o8-Lz for qemu-devel@nongnu.org; Tue, 03 Feb 2015 15:21:29 -0500 Message-ID: <54D12DC6.80004@web.de> Date: Tue, 03 Feb 2015 21:21:26 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <54CBE747.8060600@siemens.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jOd8ONJEFFkkHH0oTsXi5IP0Qv0rm6aIn" Subject: Re: [Qemu-devel] [PATCH] integrator/cp: Wire up MMC card detection List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jOd8ONJEFFkkHH0oTsXi5IP0Qv0rm6aIn Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2015-02-03 19:03, Peter Maydell wrote: > On 30 January 2015 at 20:19, Jan Kiszka wrote:= >> This allows to use MMC emulation with the Integrator/CP model. Well, >> mostly. There seems to be timing issues with Linux so that the card is= >> not always detected (but most of the time). >> >> Note that the read-only pin is intentionally left unconnected because >> the PIC model could deliver it incorrectly as interrupt to the guest >> while the spec says that this pin is just for status reading. >=20 > I'm not sure what you mean here. The WPROT signal isn't wired > up to the SIC at all as far as I can see -- it's just a read-only > bit in the CP_INTREG register in what we model as "icp_control". >=20 > Your patch doesn't seem to do anything with the icp_control at all, > which doesn't look right, because the docs say that to clear the > 'card insert' interrupt reported by the SIC you need to write > to the CP_INTREG register. >=20 > The gpio out line from the PL181 is just a status line (high when > a card is present, low if not); there needs to be a latch somewhere > in here that gets reset by the CP_INTREG write, the PL181 line > isn't just wired directly to the SIC. Indeed, read this too quickly. Let's see if modeling this more correctly will also improve the detection reliability. Jan --jOd8ONJEFFkkHH0oTsXi5IP0Qv0rm6aIn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlTRLcYACgkQitSsb3rl5xTFyACcD1/PeD1kmy2laGLgOIt4CjiH vWAAoOHt5i7nW5MZVk8CWb1LkZeaoZ9p =OUjH -----END PGP SIGNATURE----- --jOd8ONJEFFkkHH0oTsXi5IP0Qv0rm6aIn--