From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51457) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIlcQ-0007uz-BE for qemu-devel@nongnu.org; Tue, 03 Feb 2015 17:06:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIlcN-00019b-Bg for qemu-devel@nongnu.org; Tue, 03 Feb 2015 17:06:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIlcN-00019W-1Z for qemu-devel@nongnu.org; Tue, 03 Feb 2015 17:06:47 -0500 Message-ID: <54D14670.4090901@redhat.com> Date: Tue, 03 Feb 2015 15:06:40 -0700 From: Eric Blake MIME-Version: 1.0 References: <1420031214-6053-1-git-send-email-den@openvz.org> <1420031214-6053-5-git-send-email-den@openvz.org> <54D14431.4040104@redhat.com> In-Reply-To: <54D14431.4040104@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eGNeP7oj22Gfn98FS4SVVvh1reJIuPxiq" Subject: Re: [Qemu-devel] [PATCH 4/8] guest agent: add guest-pipe-open List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: qemu-devel@nongnu.org, Simon Zolin , Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --eGNeP7oj22Gfn98FS4SVVvh1reJIuPxiq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/03/2015 02:57 PM, Eric Blake wrote: >> +# Returns: Guest file handle on success, as per guest-file-open. This= >> +# handle is useable with the same interfaces as a handle returned by >=20 >> + 'returns': 'int' } >=20 > I'm not a fan of returning a bare 'int' - it is not extensible. Better= > is returning a dictionary, such as 'returns': { 'fd': 'int' }. That > way, if we ever find a reason to return multiple pieces of information,= > we just return a larger dictionary. >=20 > Yeah, I know guest-pipe-open breaks the rules here, and so consistency > may be an argument in favor of also breaking the rules. I meant to say 'guest-file-open' breaks the rules, and that you are proposing that 'guest-pipe-open' be consistent with 'guest-file-open'. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --eGNeP7oj22Gfn98FS4SVVvh1reJIuPxiq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU0UZwAAoJEKeha0olJ0Nq5y4H/1aZS8ap2zkehS8AEfFjsxgy tk7IXtlWFcgBWKQItBUcNiInq49JJZcrZa+NG41IEz/t9rlFLRLwfOUYO4y9L9+D +I9s53Qh0bai7bPKo4i3rWeo6Lnj1xWxNyyYfMSM3D3f29uvqivvW+a+vXcN0Khc A6NIldTComYblDOIqvtUXTn0iAf745Mx18BGHIMpEIS6XqhU6nJklxtm2tv/GwVw 8VzgPxOU5dWhK+yvB2BbMy28Q4ClS/XG6yYoAqy10j5myyQvk91A0tKE+iupCIpa 5LUhIHloDOytBHdM/5CKd98iPVrTSFmH/yzfj4DUpQ+9e/rVeXzrtLP9jJFzwqM= =hAAy -----END PGP SIGNATURE----- --eGNeP7oj22Gfn98FS4SVVvh1reJIuPxiq--