From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YImzg-0000uc-Sf for qemu-devel@nongnu.org; Tue, 03 Feb 2015 18:34:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YImzd-0006IL-Mj for qemu-devel@nongnu.org; Tue, 03 Feb 2015 18:34:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YImzd-0006IF-Ek for qemu-devel@nongnu.org; Tue, 03 Feb 2015 18:34:53 -0500 Message-ID: <54D15B17.1030207@redhat.com> Date: Tue, 03 Feb 2015 16:34:47 -0700 From: Eric Blake MIME-Version: 1.0 References: <1416844620-17717-1-git-send-email-mreitz@redhat.com> <1416844620-17717-4-git-send-email-mreitz@redhat.com> In-Reply-To: <1416844620-17717-4-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="H3abpCBrvXA6M7pDbJjHc9IXFGc6nbeOA" Subject: Re: [Qemu-devel] [PATCH v2 03/12] qcow2: Create metadata list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Lieven , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --H3abpCBrvXA6M7pDbJjHc9IXFGc6nbeOA Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/24/2014 08:56 AM, Max Reitz wrote: > Create and destroy the metadata list on creation and destruction of a > qcow2 BDS, respectively. Skip creation if no overlap checks should be > performed. >=20 > Signed-off-by: Max Reitz > --- > block/qcow2.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) >=20 > diff --git a/block/qcow2.c b/block/qcow2.c > index ed88d69..f80f9ed 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c > @@ -744,6 +744,13 @@ static int qcow2_open(BlockDriverState *bs, QDict = *options, int flags, > overlap_check_template & (1 << i)) << i;= > } > =20 > + if (s->overlap_check) { > + ret =3D qcow2_create_empty_metadata_list(bs, 65536, errp); Why 64k? Does this magic number need a name? Otherwise, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --H3abpCBrvXA6M7pDbJjHc9IXFGc6nbeOA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU0VsXAAoJEKeha0olJ0NqRYYIAKXQf1iTPjyfA/tPuuv7RgJJ BU6KJeMDtAIPgqn3/xPU2/ih++QN2YDGTznw0NFQ1vTemZAs+5myTdysWq4x7AOz yPTZMRWTL3Vp1oucwn48r9A7hgLr+qSsFmS9gEJPxIG2qvIXm06nyox+bvJYjRE8 cOYxtsPU5XRvSLXWFcRQ7qtoa0KdcBT+mHMCXEI78EzVQmp3m9NBkcvfUqsNTMqf hP4L5OzO89aLrC0rYehD/i6ApL5Bf9dnce5IFLtSkGLgFPQ1mrMle/D2CsWcMrtX NuDASfzgQq60ny1XMEhAKxPYN4fqNimmqJ1lPJao8rKQ1aw3hMcvpZfE0ZA8NZY= =0Bwc -----END PGP SIGNATURE----- --H3abpCBrvXA6M7pDbJjHc9IXFGc6nbeOA--