From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ2OS-0001ft-40 for qemu-devel@nongnu.org; Wed, 04 Feb 2015 11:01:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJ2ON-0002JY-TV for qemu-devel@nongnu.org; Wed, 04 Feb 2015 11:01:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60263) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ2ON-0002JO-Li for qemu-devel@nongnu.org; Wed, 04 Feb 2015 11:01:27 -0500 Message-ID: <54D24230.1020602@redhat.com> Date: Wed, 04 Feb 2015 17:00:48 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1423064635-19045-1-git-send-email-marcel@redhat.com> In-Reply-To: <1423064635-19045-1-git-send-email-marcel@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/8] machine: query machine properties rather than qemu opts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, james.hogan@imgtec.com, mst@redhat.com, jan.kiszka@siemens.com, cornelia.huck@de.ibm.com, agraf@suse.de, borntraeger@de.ibm.com, scottwood@freescale.com, leon.alrae@imgtec.com, aurelien@aurel32.net On 04/02/2015 16:43, Marcel Apfelbaum wrote: > Commit e79d5a6 ("machine: remove qemu_machine_opts global list") removed option > descriptions from the -machine QemuOptsList to avoid repeating MachineState's QOM properties. > > This results in a Qemu crash if a non string option is queried using qemu opts. > Fix this by querying machine properties through designated wrappers. Wrappers vs. direct access to fields is just a matter of taste, so Reviewed-by: Paolo Bonzini