From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ2ok-00023C-4j for qemu-devel@nongnu.org; Wed, 04 Feb 2015 11:28:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJ2og-00043f-2v for qemu-devel@nongnu.org; Wed, 04 Feb 2015 11:28:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52990) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ2of-00043S-Qn for qemu-devel@nongnu.org; Wed, 04 Feb 2015 11:28:38 -0500 Message-ID: <54D248AC.2060000@redhat.com> Date: Wed, 04 Feb 2015 17:28:28 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1422992371-4145-1-git-send-email-ehabkost@redhat.com> In-Reply-To: <1422992371-4145-1-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/9] target-i386: Simplify APIC ID initialization, move compat code to pc.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: Gu Zheng , Igor Mammedov On 03/02/2015 20:39, Eduardo Habkost wrote: > This series removes the APIC ID initialization code from x86_cpu_initfn() > (getting us one step closer to making object_new() of X86CPU have no dependency > on cpu_exec_init() and other global QEMU state), and moves the APIC ID > compatibility logic from target-i386/cpu.c to hw/i386/pc.c. > > Changes v1 -> v2: > * Move topology.h to include/hw/i386 instead of hw/i386 > * Instead of adding an apic_id_set field, make apic_id a int64_t field > and set it to -1 by default > * Check for cpu_init() errors on linux-user > > Eduardo Habkost (9): > target-i386: Move topology.h to include/hw/i386 > target-i386: Rename cpu_x86_init() to cpu_x86_init_user() > target-i386: Eliminate cpu_init() function > target-i386: Simplify error handling on cpu_x86_init_user() > target-i386: Move CPUX86State.cpuid_apic_id to X86CPU.apic_id > linux-user: Check for cpu_init() errors > target-i386: Set APIC ID using cpu_index on CONFIG_USER > target-i386: Require APIC ID to be explicitly set before CPU realize > target-i386: Move APIC ID compatibility code to pc.c > > hw/i386/pc.c | 35 ++++++++++++ > {target-i386 => include/hw/i386}/topology.h | 6 +- > linux-user/main.c | 9 ++- > target-i386/cpu-qom.h | 1 + > target-i386/cpu.c | 86 +++++++++++------------------ > target-i386/cpu.h | 13 +---- > target-i386/kvm.c | 2 +- > tests/Makefile | 2 - > tests/test-x86-cpuid.c | 2 +- > 9 files changed, 84 insertions(+), 72 deletions(-) > rename {target-i386 => include/hw/i386}/topology.h (97%) > Nice... Reviewed-by: Paolo Bonzini