From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59895)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YJ2rf-0004i5-OV
	for qemu-devel@nongnu.org; Wed, 04 Feb 2015 11:31:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YJ2rT-00065i-Vv
	for qemu-devel@nongnu.org; Wed, 04 Feb 2015 11:31:43 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45269)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YJ2rT-00064t-Pn
	for qemu-devel@nongnu.org; Wed, 04 Feb 2015 11:31:31 -0500
Message-ID: <54D2495C.2070904@redhat.com>
Date: Wed, 04 Feb 2015 11:31:24 -0500
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1416844620-17717-1-git-send-email-mreitz@redhat.com>
	<1416844620-17717-4-git-send-email-mreitz@redhat.com>
	<54D15B17.1030207@redhat.com>
In-Reply-To: <54D15B17.1030207@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 03/12] qcow2: Create metadata list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Lieven <pl@kamp.de>, Stefan Hajnoczi <stefanha@redhat.com>

On 2015-02-03 at 18:34, Eric Blake wrote:
> On 11/24/2014 08:56 AM, Max Reitz wrote:
>> Create and destroy the metadata list on creation and destruction of a
>> qcow2 BDS, respectively. Skip creation if no overlap checks should be
>> performed.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>   block/qcow2.c | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/block/qcow2.c b/block/qcow2.c
>> index ed88d69..f80f9ed 100644
>> --- a/block/qcow2.c
>> +++ b/block/qcow2.c
>> @@ -744,6 +744,13 @@ static int qcow2_open(BlockDriverState *bs, QDict *options, int flags,
>>                                 overlap_check_template & (1 << i)) << i;
>>       }
>>   
>> +    if (s->overlap_check) {
>> +        ret = qcow2_create_empty_metadata_list(bs, 65536, errp);
> Why 64k? Does this magic number need a name?

Well, maybe I should add a comment "TODO: The user should be able to 
override this default".

> Otherwise,
> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks!

Max