From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47999) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ41Q-00024R-4S for qemu-devel@nongnu.org; Wed, 04 Feb 2015 12:45:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJ41M-0000Ml-V3 for qemu-devel@nongnu.org; Wed, 04 Feb 2015 12:45:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ41M-0000MM-OR for qemu-devel@nongnu.org; Wed, 04 Feb 2015 12:45:48 -0500 Message-ID: <54D25AC5.5040507@redhat.com> Date: Wed, 04 Feb 2015 12:45:41 -0500 From: Max Reitz MIME-Version: 1.0 References: <1423042352-361-1-git-send-email-chenxg@linux.vnet.ibm.com> <1423042352-361-2-git-send-email-chenxg@linux.vnet.ibm.com> In-Reply-To: <1423042352-361-2-git-send-email-chenxg@linux.vnet.ibm.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC v3 1/6] qemu-iotests: fix tests 067, 071 and 087 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guang Chen , qemu-devel@nongnu.org Cc: kwolf@redhat.com, mimu@linux.vnet.ibm.com, armbru@redhat.com On 2015-02-04 at 04:32, Xiao Guang Chen wrote: > From: Xiao Guang Chen > > Update the output files for test case 067, 071 and 087 because qemu option > -nodefaults was used to start a guest so there are no default floppy and > cdrom for guests any more. > Use virtio-blk instead of virtio-blk-pci as the device driver for test case > 067. For virtio-blk-pci is the same with virtio-blk as device driver but > other platform such as s390 may not recognize the virtio-blk-pci. > > Reviewed-by: Michael Mueller > Signed-off-by: Xiao Guang Chen > --- > tests/qemu-iotests/067 | 8 ++++---- > tests/qemu-iotests/067.out | 26 +++++++++----------------- > tests/qemu-iotests/071.out | 12 ++++-------- > tests/qemu-iotests/087.out | 18 +++--------------- > 4 files changed, 20 insertions(+), 44 deletions(-) First of all, this patch needs to be rebased (it doesn't apply on qemu's current master branch any more (without manual fixing)). Second, I think this patch belongs after patch 3 (or should be squashed into it, considering that commits should not break tests), because as it is here, it breaks these tests on x86. Max