From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ4US-0005a8-6P for qemu-devel@nongnu.org; Wed, 04 Feb 2015 13:15:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJ4UO-0002EO-1f for qemu-devel@nongnu.org; Wed, 04 Feb 2015 13:15:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ4UN-0002EK-QD for qemu-devel@nongnu.org; Wed, 04 Feb 2015 13:15:47 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t14IFkNf001898 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 4 Feb 2015 13:15:46 -0500 Message-ID: <54D261D1.3090905@redhat.com> Date: Wed, 04 Feb 2015 11:15:45 -0700 From: Eric Blake MIME-Version: 1.0 References: <1423063902-4926-1-git-send-email-stefanha@redhat.com> <1423072297-1842-1-git-send-email-eblake@redhat.com> <54D25E82.8010000@redhat.com> In-Reply-To: <54D25E82.8010000@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ml24fC5UNPos8c5sdcmI7SROFIbdG6sL1" Subject: Re: [Qemu-devel] [PATCH reformat] block: move I/O request processing to block/io.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Ml24fC5UNPos8c5sdcmI7SROFIbdG6sL1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/04/2015 11:01 AM, Eric Blake wrote: > On 02/04/2015 10:51 AM, Eric Blake wrote: >> From: Stefan Hajnoczi >> >> The block.c file has grown to over 6000 lines. It is time to split th= is >> file so there are fewer conflicts and the code is easier to maintain. >> >> This patch produces identical results to Stefan's email, but is >> MUCH more readable (hint: git config diff.algorithm patience) >> >> block.c | 1980 +-----------------------------------= -------- >> block/Makefile.objs | 1 + >> block/io.c | 1997 ++++++++++++++++++++++++++++++++++++= +++++++++ >> include/block/block_int.h | 14 + >> 4 files changed, 2015 insertions(+), 1977 deletions(-) >> create mode 100644 block/io.c >=20 > And here's how I reviewed it: > $ git format-patch --stdout -1 > patch > $ diff -u <(sed -n 's/^-//p' patch) <(sed -n 's/^\+//p' patch) I've updated http://wiki.qemu.org/Contribute/SubmitAPatch with this hint.= --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Ml24fC5UNPos8c5sdcmI7SROFIbdG6sL1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU0mHRAAoJEKeha0olJ0NqHWQH/066onI10vgspfLvEd/ZRWlD u+SZ4W8JBOEO+fauIEGVw4A/x4bLjrYQpdWtRh1aA2xa6QldggzsyIrLFtmM1pan TJMBVo+oieBsHMXsMkRN6qhRoK3q3JXIEcyVsVxQtUZ8YJJJp4DTZFMdY5ZI1qwP UowkV2TSm7OUKI0TR2nd7/bQRApf4M87dHScWNd3VGUrzqmbLE2PWW9Um8Mw41sr Sspg+U609k9YhwrnCl7LMJzSdMrtqVK9NIBX1fyWkE7+GmtWEsKjZXh0ZVeEpSAP I6WJUT7K+RKDCCUNkeaXMQb6VtuLWE/+rgbWDdWWAta6rBg9odVdVE5NWho/dYM= =JE49 -----END PGP SIGNATURE----- --Ml24fC5UNPos8c5sdcmI7SROFIbdG6sL1--