[Qemu-devel] [PATCH] vl.c: fixed QEMU crash if no display was selected in command line

[Qemu-devel] [PATCH] vl.c: fixed QEMU crash if no display was selected in command line

[Marcel Apfelbaum]

Commit 4db14629c3 (vnc: switch to QemuOpts, allow multiple servers)
converted vnc option to QemuOpts.
However, the default vnc display had ...,to=99,... between parameters
that is not covered by the QemuOpts.
Remove it because is not longer used and solves the crash.

Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
---
This issue is bugging me some time now. Please let me know if
I got it wrong.

 vl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/vl.c b/vl.c
index 983259b..c8f33d2 100644
--- a/vl.c
+++ b/vl.c
@@ -3970,7 +3970,7 @@ int main(int argc, char **argv, char **envp)
 #elif defined(CONFIG_SDL) || defined(CONFIG_COCOA)
         display_type = DT_SDL;
 #elif defined(CONFIG_VNC)
-        vnc_parse_func("localhost:0,to=99,id=default");
+        vnc_parse_func("localhost:0,id=default");
         show_vnc_port = 1;
 #else
         display_type = DT_NONE;
-- 
2.1.0

Re: [Qemu-devel] [PATCH] vl.c: fixed QEMU crash if no display was selected in command line

[Don Slutz]

A proper fix for this is the thread:

Subject: [PATCH v2 0/3] fix qemu crash about vnc
Date: Fri, 30 Jan 2015 10:14:33 +0800
Message-ID: <1422584076-5728-1-git-send-email-arei.gonglei@huawei.com>

This also has a bug:

https://bugs.launchpad.net/qemu/+bug/1414222


Xen expects this to be working.

   -Don Slutz


On 02/04/15 06:25, Marcel Apfelbaum wrote:
> Commit 4db14629c3 (vnc: switch to QemuOpts, allow multiple servers)
> converted vnc option to QemuOpts.
> However, the default vnc display had ...,to=99,... between parameters
> that is not covered by the QemuOpts.
> Remove it because is not longer used and solves the crash.
> 
> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
> ---
> This issue is bugging me some time now. Please let me know if
> I got it wrong.
> 
>  vl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/vl.c b/vl.c
> index 983259b..c8f33d2 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3970,7 +3970,7 @@ int main(int argc, char **argv, char **envp)
>  #elif defined(CONFIG_SDL) || defined(CONFIG_COCOA)
>          display_type = DT_SDL;
>  #elif defined(CONFIG_VNC)
> -        vnc_parse_func("localhost:0,to=99,id=default");
> +        vnc_parse_func("localhost:0,id=default");
>          show_vnc_port = 1;
>  #else
>          display_type = DT_NONE;
> 

Re: [Qemu-devel] [PATCH] vl.c: fixed QEMU crash if no display was selected in command line

[Marcel Apfelbaum]

On 02/04/2015 10:40 PM, Don Slutz wrote:
> A proper fix for this is the thread:
I suspected I don't have the whole picture, good to know it is fixed!

Thanks!
Marcel

>
> Subject: [PATCH v2 0/3] fix qemu crash about vnc
> Date: Fri, 30 Jan 2015 10:14:33 +0800
> Message-ID: <1422584076-5728-1-git-send-email-arei.gonglei@huawei.com>
>
> This also has a bug:
>
> https://bugs.launchpad.net/qemu/+bug/1414222
>
>
> Xen expects this to be working.
>
>     -Don Slutz
>
[...]