From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJFNo-0003dm-1X for qemu-devel@nongnu.org; Thu, 05 Feb 2015 00:53:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJFNi-0006gb-Va for qemu-devel@nongnu.org; Thu, 05 Feb 2015 00:53:43 -0500 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:57197) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJFNi-0006gX-B8 for qemu-devel@nongnu.org; Thu, 05 Feb 2015 00:53:38 -0500 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 5 Feb 2015 15:53:35 +1000 Received: from d23relay08.au.ibm.com (d23relay08.au.ibm.com [9.185.71.33]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 5FFCA2CE8040 for ; Thu, 5 Feb 2015 16:53:33 +1100 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay08.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t155rOTE41287838 for ; Thu, 5 Feb 2015 16:53:33 +1100 Received: from d23av02.au.ibm.com (localhost [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t155qxJZ014046 for ; Thu, 5 Feb 2015 16:52:59 +1100 Message-ID: <54D30522.4070006@linux.vnet.ibm.com> Date: Thu, 05 Feb 2015 13:52:34 +0800 From: chen xiao guang MIME-Version: 1.0 References: <1423107872-3268-1-git-send-email-chenxg@linux.vnet.ibm.com> <1423107872-3268-2-git-send-email-chenxg@linux.vnet.ibm.com> <20150205035255.GA7531@ad.nay.redhat.com> In-Reply-To: <20150205035255.GA7531@ad.nay.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC v4 1/6] qemu-iotests: run qemu with -nodefaults List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, mimu@linux.vnet.ibm.com, mreitz@redhat.com On 02/05/2015 11:52 AM, Fam Zheng wrote: > On Thu, 02/05 11:44, Xiao Guang Chen wrote: >> This patch fixes an io test suite issue that was introduced with the >> commit c88930a6866e74953e931ae749781e98e486e5c8 'qemu-char: Permit only >> a single "stdio" character device'. The option supresses the creation of >> default devices. >> >> Reviewed-by: Michael Mueller >> Signed-off-by: Xiao Guang Chen >> --- >> tests/qemu-iotests/common | 1 + >> tests/qemu-iotests/common.config | 2 +- >> tests/qemu-iotests/common.qemu | 2 +- >> 3 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common >> index 1e556bb..ed26d79 100644 >> --- a/tests/qemu-iotests/common >> +++ b/tests/qemu-iotests/common >> @@ -51,6 +51,7 @@ export IMGOPTS="" >> export CACHEMODE="writeback" >> export QEMU_IO_OPTIONS="" >> export CACHEMODE_IS_DEFAULT=true >> +export QEMU_OPTIONS="-nodefaults" >> >> for r >> do >> diff --git a/tests/qemu-iotests/common.config b/tests/qemu-iotests/common.config >> index a1973ad..cff91e1 100644 >> --- a/tests/qemu-iotests/common.config >> +++ b/tests/qemu-iotests/common.config >> @@ -103,7 +103,7 @@ if [ -z "$QEMU_NBD_PROG" ]; then >> export QEMU_NBD_PROG="`set_prog_path qemu-nbd`" >> fi >> >> -export QEMU=$QEMU_PROG >> +export QEMU="$QEMU_PROG $QEMU_OPTIONS" >> export QEMU_IMG=$QEMU_IMG_PROG >> export QEMU_IO="$QEMU_IO_PROG $QEMU_IO_OPTIONS" >> export QEMU_NBD=$QEMU_NBD_PROG >> diff --git a/tests/qemu-iotests/common.qemu b/tests/qemu-iotests/common.qemu >> index 8e618b5..e35a797 100644 >> --- a/tests/qemu-iotests/common.qemu >> +++ b/tests/qemu-iotests/common.qemu >> @@ -153,7 +153,7 @@ function _launch_qemu() >> mkfifo "${fifo_out}" >> mkfifo "${fifo_in}" >> >> - "${QEMU}" -nographic -serial none ${comm} -machine accel=qtest "${@}" \ >> + ${QEMU} -nographic -serial none ${comm} -machine accel=qtest "${@}" \ > I believe the reason to quote ${QEMU} was allow paths containing whitespaces. > Why not leave the quotes unchanged and add $QEMU_OPTIONS here? I think the reason is to keep a consistent calling style with other qemu facilities such as: QEMU_IO. Chen > Fam > >