From: Paolo Bonzini <pbonzini@redhat.com>
To: Zhang Haoyu <zhanghy@sangfor.com.cn>, qemu-devel <qemu-devel@nongnu.org>
Cc: Amit Shah <amit.shah@redhat.com>, "Michael S.Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] fix mc146818rtc wrong subsection name to avoid vmstate_subsection_load() fail
Date: Thu, 05 Feb 2015 12:35:02 +0100 [thread overview]
Message-ID: <54D35566.1070704@redhat.com> (raw)
In-Reply-To: <201502051933093705711@sangfor.com.cn>
On 05/02/2015 12:33, Zhang Haoyu wrote:
> fix mc146818rtc wrong subsection name to avoid vmstate_subsection_load() fail
> during incoming migration or loadvm.
>
> Signed-off-by: Zhang Haoyu <zhanghy@sangfor.com.cn>
> ---
> hw/timer/mc146818rtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c
> index 5a107fa..0600c9a 100644
> --- a/hw/timer/mc146818rtc.c
> +++ b/hw/timer/mc146818rtc.c
> @@ -734,7 +734,7 @@ static int rtc_post_load(void *opaque, int version_id)
> }
>
> static const VMStateDescription vmstate_rtc_irq_reinject_on_ack_count = {
> - .name = "irq_reinject_on_ack_count",
> + .name = "mc146818rtc/irq_reinject_on_ack_count",
> .version_id = 1,
> .minimum_version_id = 1,
> .fields = (VMStateField[]) {
>
Adding Amit.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
It would be nice if registering a subsection automatically caught
wrongly-named ones...
Paolo
next prev parent reply other threads:[~2015-02-05 11:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 11:33 [Qemu-devel] [PATCH] fix mc146818rtc wrong subsection name to avoid vmstate_subsection_load() fail Zhang Haoyu
2015-02-05 11:35 ` Paolo Bonzini [this message]
2015-02-05 12:49 ` Juan Quintela
2015-02-05 13:05 ` Paolo Bonzini
2015-02-05 12:48 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D35566.1070704@redhat.com \
--to=pbonzini@redhat.com \
--cc=amit.shah@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhanghy@sangfor.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).