From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41270)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YJKiJ-0007pP-JP
	for qemu-devel@nongnu.org; Thu, 05 Feb 2015 06:35:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YJKiD-0003nQ-SA
	for qemu-devel@nongnu.org; Thu, 05 Feb 2015 06:35:15 -0500
Received: from mx1.redhat.com ([209.132.183.28]:60204)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YJKiD-0003nB-LT
	for qemu-devel@nongnu.org; Thu, 05 Feb 2015 06:35:09 -0500
Message-ID: <54D35566.1070704@redhat.com>
Date: Thu, 05 Feb 2015 12:35:02 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <201502051933093705711@sangfor.com.cn>
In-Reply-To: <201502051933093705711@sangfor.com.cn>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] fix mc146818rtc wrong subsection name to
 avoid vmstate_subsection_load() fail
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Zhang Haoyu <zhanghy@sangfor.com.cn>, qemu-devel <qemu-devel@nongnu.org>
Cc: Amit Shah <amit.shah@redhat.com>, "Michael S.Tsirkin" <mst@redhat.com>

On 05/02/2015 12:33, Zhang Haoyu wrote:
> fix mc146818rtc wrong subsection name to avoid vmstate_subsection_load() fail
> during incoming migration or loadvm.
> 
> Signed-off-by: Zhang Haoyu <zhanghy@sangfor.com.cn>
> ---
>  hw/timer/mc146818rtc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c
> index 5a107fa..0600c9a 100644
> --- a/hw/timer/mc146818rtc.c
> +++ b/hw/timer/mc146818rtc.c
> @@ -734,7 +734,7 @@ static int rtc_post_load(void *opaque, int version_id)
>  }
>  
>  static const VMStateDescription vmstate_rtc_irq_reinject_on_ack_count = {
> -    .name = "irq_reinject_on_ack_count",
> +    .name = "mc146818rtc/irq_reinject_on_ack_count",
>      .version_id = 1,
>      .minimum_version_id = 1,
>      .fields = (VMStateField[]) {
> 

Adding Amit.

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

It would be nice if registering a subsection automatically caught
wrongly-named ones...

Paolo