* [Qemu-devel] [PATCH] fix mc146818rtc wrong subsection name to avoid vmstate_subsection_load() fail
@ 2015-02-05 11:33 Zhang Haoyu
2015-02-05 11:35 ` Paolo Bonzini
2015-02-05 12:48 ` Juan Quintela
0 siblings, 2 replies; 5+ messages in thread
From: Zhang Haoyu @ 2015-02-05 11:33 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Michael S.Tsirkin
fix mc146818rtc wrong subsection name to avoid vmstate_subsection_load() fail
during incoming migration or loadvm.
Signed-off-by: Zhang Haoyu <zhanghy@sangfor.com.cn>
---
hw/timer/mc146818rtc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c
index 5a107fa..0600c9a 100644
--- a/hw/timer/mc146818rtc.c
+++ b/hw/timer/mc146818rtc.c
@@ -734,7 +734,7 @@ static int rtc_post_load(void *opaque, int version_id)
}
static const VMStateDescription vmstate_rtc_irq_reinject_on_ack_count = {
- .name = "irq_reinject_on_ack_count",
+ .name = "mc146818rtc/irq_reinject_on_ack_count",
.version_id = 1,
.minimum_version_id = 1,
.fields = (VMStateField[]) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] fix mc146818rtc wrong subsection name to avoid vmstate_subsection_load() fail
2015-02-05 11:33 [Qemu-devel] [PATCH] fix mc146818rtc wrong subsection name to avoid vmstate_subsection_load() fail Zhang Haoyu
@ 2015-02-05 11:35 ` Paolo Bonzini
2015-02-05 12:49 ` Juan Quintela
2015-02-05 12:48 ` Juan Quintela
1 sibling, 1 reply; 5+ messages in thread
From: Paolo Bonzini @ 2015-02-05 11:35 UTC (permalink / raw)
To: Zhang Haoyu, qemu-devel; +Cc: Amit Shah, Michael S.Tsirkin
On 05/02/2015 12:33, Zhang Haoyu wrote:
> fix mc146818rtc wrong subsection name to avoid vmstate_subsection_load() fail
> during incoming migration or loadvm.
>
> Signed-off-by: Zhang Haoyu <zhanghy@sangfor.com.cn>
> ---
> hw/timer/mc146818rtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c
> index 5a107fa..0600c9a 100644
> --- a/hw/timer/mc146818rtc.c
> +++ b/hw/timer/mc146818rtc.c
> @@ -734,7 +734,7 @@ static int rtc_post_load(void *opaque, int version_id)
> }
>
> static const VMStateDescription vmstate_rtc_irq_reinject_on_ack_count = {
> - .name = "irq_reinject_on_ack_count",
> + .name = "mc146818rtc/irq_reinject_on_ack_count",
> .version_id = 1,
> .minimum_version_id = 1,
> .fields = (VMStateField[]) {
>
Adding Amit.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
It would be nice if registering a subsection automatically caught
wrongly-named ones...
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] fix mc146818rtc wrong subsection name to avoid vmstate_subsection_load() fail
2015-02-05 11:35 ` Paolo Bonzini
@ 2015-02-05 12:49 ` Juan Quintela
2015-02-05 13:05 ` Paolo Bonzini
0 siblings, 1 reply; 5+ messages in thread
From: Juan Quintela @ 2015-02-05 12:49 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Amit Shah, Zhang Haoyu, qemu-devel, Michael S.Tsirkin
Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 05/02/2015 12:33, Zhang Haoyu wrote:
>> fix mc146818rtc wrong subsection name to avoid vmstate_subsection_load() fail
>> during incoming migration or loadvm.
>>
>> Signed-off-by: Zhang Haoyu <zhanghy@sangfor.com.cn>
>> ---
>> hw/timer/mc146818rtc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c
>> index 5a107fa..0600c9a 100644
>> --- a/hw/timer/mc146818rtc.c
>> +++ b/hw/timer/mc146818rtc.c
>> @@ -734,7 +734,7 @@ static int rtc_post_load(void *opaque, int version_id)
>> }
>>
>> static const VMStateDescription vmstate_rtc_irq_reinject_on_ack_count = {
>> - .name = "irq_reinject_on_ack_count",
>> + .name = "mc146818rtc/irq_reinject_on_ack_count",
>> .version_id = 1,
>> .minimum_version_id = 1,
>> .fields = (VMStateField[]) {
>>
>
> Adding Amit.
>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>
> It would be nice if registering a subsection automatically caught
> wrongly-named ones...
You are right here.
THere is another check that I would like, that we only have subsections
at the top livel.
Thanks, JUan.
> Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] fix mc146818rtc wrong subsection name to avoid vmstate_subsection_load() fail
2015-02-05 12:49 ` Juan Quintela
@ 2015-02-05 13:05 ` Paolo Bonzini
0 siblings, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2015-02-05 13:05 UTC (permalink / raw)
To: quintela; +Cc: Amit Shah, Zhang Haoyu, qemu-devel, Michael S.Tsirkin
On 05/02/2015 13:49, Juan Quintela wrote:
>> > It would be nice if registering a subsection automatically caught
>> > wrongly-named ones...
> You are right here.
>
> THere is another check that I would like, that we only have subsections
> at the top livel.
You mean not inside structs? IIRC that would fail.
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] fix mc146818rtc wrong subsection name to avoid vmstate_subsection_load() fail
2015-02-05 11:33 [Qemu-devel] [PATCH] fix mc146818rtc wrong subsection name to avoid vmstate_subsection_load() fail Zhang Haoyu
2015-02-05 11:35 ` Paolo Bonzini
@ 2015-02-05 12:48 ` Juan Quintela
1 sibling, 0 replies; 5+ messages in thread
From: Juan Quintela @ 2015-02-05 12:48 UTC (permalink / raw)
To: Zhang Haoyu; +Cc: Paolo Bonzini, qemu-devel, Michael S.Tsirkin
"Zhang Haoyu" <zhanghy@sangfor.com.cn> wrote:
> fix mc146818rtc wrong subsection name to avoid vmstate_subsection_load() fail
> during incoming migration or loadvm.
>
> Signed-off-by: Zhang Haoyu <zhanghy@sangfor.com.cn>
> ---
> hw/timer/mc146818rtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c
> index 5a107fa..0600c9a 100644
> --- a/hw/timer/mc146818rtc.c
> +++ b/hw/timer/mc146818rtc.c
> @@ -734,7 +734,7 @@ static int rtc_post_load(void *opaque, int version_id)
> }
>
> static const VMStateDescription vmstate_rtc_irq_reinject_on_ack_count = {
> - .name = "irq_reinject_on_ack_count",
> + .name = "mc146818rtc/irq_reinject_on_ack_count",
> .version_id = 1,
> .minimum_version_id = 1,
> .fields = (VMStateField[]) {
Ack
applied to my tree.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-02-05 13:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-05 11:33 [Qemu-devel] [PATCH] fix mc146818rtc wrong subsection name to avoid vmstate_subsection_load() fail Zhang Haoyu
2015-02-05 11:35 ` Paolo Bonzini
2015-02-05 12:49 ` Juan Quintela
2015-02-05 13:05 ` Paolo Bonzini
2015-02-05 12:48 ` Juan Quintela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).