From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJMQH-0004Hn-Q7 for qemu-devel@nongnu.org; Thu, 05 Feb 2015 08:24:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJMQC-0007Hk-1k for qemu-devel@nongnu.org; Thu, 05 Feb 2015 08:24:45 -0500 Message-ID: <54D36F16.8050202@suse.de> Date: Thu, 05 Feb 2015 14:24:38 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1421704772-10394-1-git-send-email-hpoussin@reactos.org> <54CE6BD8.6000305@ilande.co.uk> In-Reply-To: <54CE6BD8.6000305@ilande.co.uk> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/4] timer/m48t59: QOM'ify List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland , =?UTF-8?B?SGVydsOpIA==?= =?UTF-8?B?UG91c3NpbmVhdQ==?= , qemu-devel@nongnu.org Cc: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-ppc@nongnu.org On 01.02.15 19:09, Mark Cave-Ayland wrote: > On 19/01/15 21:59, Herv=C3=A9 Poussineau wrote: >=20 >> Hi, >> >> This patchset QOM'ifies the m48t59 timer. >> Patch 1 allows the creation of the m4859 ISA device from the command l= ine. >> Patch 2 QOM'ifies the device. >> Patches 3 add a Nvram interface to m48txx devices, so that callers can >> detect the device and use it without knowing m48txx internals. >> Patch 4 is using this new Nvram interface and cleaning the m48t59 head= er. >> >> Patches 3 and 4 are not needed for m48t59 QOM'ification, but are in my >> opinion a nice cleanup. >> >> Herv=C3=A9 Poussineau (4): >> m48t59: move ISA ports/memory regions registration to QOM constructo= r >> m48t59: register a QOM type for each nvram type we support >> m48t59: add a Nvram interface >> m48t59: let init functions return a Nvram object >> >> hw/ppc/ppc.c | 161 ---------------------- >> hw/ppc/prep.c | 161 ++++++++++++++++++++-- >> hw/sparc/sun4m.c | 8 +- >> hw/sparc64/sun4u.c | 10 +- >> hw/timer/m48t59.c | 336 ++++++++++++++++++++++++++++++++----= --------- >> include/hw/timer/m48t59.h | 60 ++++---- >> 6 files changed, 429 insertions(+), 307 deletions(-) >=20 > I've tested this in conjunction with a rebased version of my sun4u NVRA= M > changes for SPARC32 and SPARC64 and it looks good so: >=20 > Tested-by: Mark Cave-Ayland >=20 > I'll post a new version of my sun4u NVRAM changes rebased on your two > patchsets shortly. Acked-by: Alexander Graf Andreas, I suppose this one should go via your tree? It's quite prep specific. Alex