From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJNK6-0001xk-PJ for qemu-devel@nongnu.org; Thu, 05 Feb 2015 09:22:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJNK0-00072U-CI for qemu-devel@nongnu.org; Thu, 05 Feb 2015 09:22:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41759) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJNK0-00072L-5W for qemu-devel@nongnu.org; Thu, 05 Feb 2015 09:22:20 -0500 Message-ID: <54D37C95.3060101@redhat.com> Date: Thu, 05 Feb 2015 09:22:13 -0500 From: Max Reitz MIME-Version: 1.0 References: <1423107872-3268-1-git-send-email-chenxg@linux.vnet.ibm.com> <1423107872-3268-2-git-send-email-chenxg@linux.vnet.ibm.com> In-Reply-To: <1423107872-3268-2-git-send-email-chenxg@linux.vnet.ibm.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC v4 1/6] qemu-iotests: run qemu with -nodefaults List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guang Chen , qemu-devel@nongnu.org Cc: kwolf@redhat.com, mimu@linux.vnet.ibm.com, armbru@redhat.com On 2015-02-04 at 22:44, Xiao Guang Chen wrote: > This patch fixes an io test suite issue that was introduced with the > commit c88930a6866e74953e931ae749781e98e486e5c8 'qemu-char: Permit only > a single "stdio" character device'. The option supresses the creation of > default devices. > > Reviewed-by: Michael Mueller > Signed-off-by: Xiao Guang Chen > --- > tests/qemu-iotests/common | 1 + > tests/qemu-iotests/common.config | 2 +- > tests/qemu-iotests/common.qemu | 2 +- > 3 files changed, 3 insertions(+), 2 deletions(-) I think this patch and patch 3 are fine, but there is no reason not to squash 3 into 1. The reason I'm suggesting that once again is that it prevents tests 067, 071, and 087 from breaking (which would be a really nice thing). So if you decide not to squash them I'll probably give an Reviewed-by anyway, but you really should consider doing it. Max