From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56173)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YJNOR-0006rK-RD
	for qemu-devel@nongnu.org; Thu, 05 Feb 2015 09:26:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YJNOO-0000Hc-Ke
	for qemu-devel@nongnu.org; Thu, 05 Feb 2015 09:26:55 -0500
Received: from mx1.redhat.com ([209.132.183.28]:41551)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YJNON-0000Gy-OU
	for qemu-devel@nongnu.org; Thu, 05 Feb 2015 09:26:52 -0500
Message-ID: <54D37DA5.3090807@redhat.com>
Date: Thu, 05 Feb 2015 09:26:45 -0500
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1423107872-3268-1-git-send-email-chenxg@linux.vnet.ibm.com>
	<1423107872-3268-5-git-send-email-chenxg@linux.vnet.ibm.com>
In-Reply-To: <1423107872-3268-5-git-send-email-chenxg@linux.vnet.ibm.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RFC v4 4/6] qemu-iotests: s390x: fix test
	041
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Xiao Guang Chen <chenxg@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, mimu@linux.vnet.ibm.com, armbru@redhat.com

On 2015-02-04 at 22:44, Xiao Guang Chen wrote:
> From: Mao Chuan Li <maochuan@linux.vnet.ibm.com>
>
> There is no such device 'ide-cd' defined on the s390 platform, so
> test_medium_not_found() test is skipped.
>
> Reviewed-by:   Michael Mueller <mimu@linux.vnet.ibm.com>
> Signed-off-by: Mao Chuan Li  <maochuan@linux.vnet.ibm.com>
> ---
>   tests/qemu-iotests/041 | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
> index 59a8f73..4fb1b34 100755
> --- a/tests/qemu-iotests/041
> +++ b/tests/qemu-iotests/041
> @@ -197,6 +197,9 @@ class TestSingleDrive(ImageMirroringTestCase):
>                           'target image does not match source after mirroring')
>   
>       def test_medium_not_found(self):
> +	if iotests.qemu_default_machine == 's390-virtio':
> +	    return
> +
>           result = self.vm.qmp('drive-mirror', device='ide1-cd0', sync='full',
>                                target=target_img)
>           self.assert_qmp(result, 'error/class', 'GenericError')
> @@ -867,6 +870,9 @@ class TestRepairQuorum(ImageMirroringTestCase):
>           if not self.has_quorum():
>               return
>   
> +        if iotests.qemu_default_machine == 's390-virtio':
> +	    return
> +
>           result = self.vm.qmp('drive-mirror', device='ide1-cd0', sync='full',
>                                node_name='repair0',
>                                replaces='img1',

Please don't use tabs for indentation.

With the tabs replaced by eight spaces each:

Reviewed-by: Max Reitz <mreitz@redhat.com>