From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJOMf-0007nM-4b for qemu-devel@nongnu.org; Thu, 05 Feb 2015 10:29:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJOMe-0005QE-6s for qemu-devel@nongnu.org; Thu, 05 Feb 2015 10:29:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJOMd-0005Q1-UR for qemu-devel@nongnu.org; Thu, 05 Feb 2015 10:29:08 -0500 Message-ID: <54D38C3E.4090605@redhat.com> Date: Thu, 05 Feb 2015 08:29:02 -0700 From: Eric Blake MIME-Version: 1.0 References: <1416844620-17717-1-git-send-email-mreitz@redhat.com> <1416844620-17717-10-git-send-email-mreitz@redhat.com> In-Reply-To: <1416844620-17717-10-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="L74QcsamOkEK7wFXOUsQCqnKxI5MnmfpT" Subject: Re: [Qemu-devel] [PATCH v2 09/12] qcow2/overlaps: Protect snapshot table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Lieven , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --L74QcsamOkEK7wFXOUsQCqnKxI5MnmfpT Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/24/2014 08:56 AM, Max Reitz wrote: > Keep track of the snapshot table in the metadata list to protect it > against accidental modifications. >=20 > Signed-off-by: Max Reitz > --- > block/qcow2-snapshot.c | 10 ++++++++++ > block/qcow2.c | 6 ++++++ > 2 files changed, 16 insertions(+) >=20 > + if (header.nb_snapshots) { > + qcow2_metadata_list_enter(bs, header.snapshots_offset, > + size_to_clusters(s, header.nb_snapsh= ots * > + sizeof(QCowSnapshot= Header)), In other patches in this series, you had been aligning the sizeof() with the parameter expression it continues, rather than the first parameter. blah(s, count * sizeof(struct)) vs. blah(s, count * sizeof(struct)) I don't care either way, just wanted to point it out, in case you care. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --L74QcsamOkEK7wFXOUsQCqnKxI5MnmfpT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU04w+AAoJEKeha0olJ0Nq8VQIALAKj4P10Jg/98+3CrbRZh8n Ph9RVJ+SLoeA8JlkhpHAoz9Y/5Yj6LlNC2gTFfpI32coKvu+umcJcysNNvE+4MeH Hm8edC2bTkprjmYy833uQDmU13hqMRFGHLR7I5fPozWmFfeimtSdsJkI/0XMyoZu 13poLixytRbLJQ7cLQbHq8C7SqlTXAYQtm6WEcm1rmFWT7za+OMZHKdWuK5f4QQO RRdtBaNlp91P5pUmAKJ0T2TL4aLdC6a0FvD2C5Umg5bV4EWHdoEaa9gwXmHtUkYC PXteZPfEzzEPf+WD/tdGpU311v2jjCON7ndo0yqHlpO83u/VQpEn6bmudpZfs6c= =qSxi -----END PGP SIGNATURE----- --L74QcsamOkEK7wFXOUsQCqnKxI5MnmfpT--