From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJOTk-00061e-7M for qemu-devel@nongnu.org; Thu, 05 Feb 2015 10:36:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJOTg-0008My-7p for qemu-devel@nongnu.org; Thu, 05 Feb 2015 10:36:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51288) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJOTf-0008Ms-Vv for qemu-devel@nongnu.org; Thu, 05 Feb 2015 10:36:24 -0500 Message-ID: <54D38DF0.4030000@redhat.com> Date: Thu, 05 Feb 2015 17:36:16 +0200 From: Marcel Apfelbaum MIME-Version: 1.0 References: <1421938231-25698-1-git-send-email-imammedo@redhat.com> <1421938231-25698-36-git-send-email-imammedo@redhat.com> In-Reply-To: <1421938231-25698-36-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 35/47] acpi: add acpi_reserved_field() term List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, drjones@redhat.com, marcel.a@redhat.com, claudio.fontana@huawei.com, mst@redhat.com On 01/22/2015 04:50 PM, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > hw/acpi/acpi-build-utils.c | 10 ++++++++++ > include/hw/acpi/acpi-build-utils.h | 6 ++++++ > 2 files changed, 16 insertions(+) > > diff --git a/hw/acpi/acpi-build-utils.c b/hw/acpi/acpi-build-utils.c > index cbc1241..644af1f 100644 > --- a/hw/acpi/acpi-build-utils.c > +++ b/hw/acpi/acpi-build-utils.c > @@ -591,6 +591,16 @@ AcpiAml acpi_named_field(const char *name, unsigned length) > return var; > } > > +/* ACPI 5.0: 20.2.5.2 Named Objects Encoding: ReservedField */ > +AcpiAml acpi_reserved_field(unsigned length) > +{ > + AcpiAml var = aml_allocate_internal(0, NON_BLOCK); > + /* ReservedField := 0x00 PkgLength */ > + build_append_byte(var.buf, 0x00); > + build_append_pkg_length(var.buf, length, false); > + return var; > +} > + > /* ACPI 5.0: 20.2.5.2 Named Objects Encoding: DefField */ > AcpiAml acpi_field(const char *name, acpiFieldFlags flags) > { > diff --git a/include/hw/acpi/acpi-build-utils.h b/include/hw/acpi/acpi-build-utils.h > index 02d5aa8..048ed26 100644 > --- a/include/hw/acpi/acpi-build-utils.h > +++ b/include/hw/acpi/acpi-build-utils.h > @@ -25,7 +25,12 @@ typedef enum { > } acpiIODecode; ^^^ > > typedef enum { > + acpi_any_acc = 0, > acpi_byte_acc = 1, > + acpi_word_acc = 2, > + acpi_dword_acc = 3, > + acpi_qword_acc = 4, > + acpi_buffer_acc = 5, > } acpiFieldFlags; ^^^ I missed that, is there any way it was like that already? Do we have such a coding convention on QEMU? Thanks, Marcel > > typedef enum { > @@ -58,6 +63,7 @@ AcpiAml acpi_io(acpiIODecode dec, uint16_t min_base, uint16_t max_base, > AcpiAml acpi_operation_region(const char *name, acpiRegionSpace rs, > uint32_t offset, uint32_t len); > AcpiAml acpi_named_field(const char *name, unsigned length); > +AcpiAml acpi_reserved_field(unsigned length); > AcpiAml GCC_FMT_ATTR(1, 2) acpi_string(const char *name_format, ...); > AcpiAml acpi_local0(void); > AcpiAml acpi_equal(AcpiAml arg1, AcpiAml arg2); >