From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJSxJ-0006G1-4n for qemu-devel@nongnu.org; Thu, 05 Feb 2015 15:23:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJSxF-0006Me-2I for qemu-devel@nongnu.org; Thu, 05 Feb 2015 15:23:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJSxE-0006MZ-Pr for qemu-devel@nongnu.org; Thu, 05 Feb 2015 15:23:13 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t15KNCOk007044 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 5 Feb 2015 15:23:12 -0500 Message-ID: <54D3D12E.7070508@redhat.com> Date: Thu, 05 Feb 2015 13:23:10 -0700 From: Eric Blake MIME-Version: 1.0 References: <1423162705-32065-1-git-send-email-mreitz@redhat.com> <1423162705-32065-6-git-send-email-mreitz@redhat.com> In-Reply-To: <1423162705-32065-6-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5V9jJXcDllkKBfmpaHoF0Kcr9TVvrQ9GE" Subject: Re: [Qemu-devel] [PATCH v4 05/16] blockdev: Use blk_new_open() in blockdev_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5V9jJXcDllkKBfmpaHoF0Kcr9TVvrQ9GE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/05/2015 11:58 AM, Max Reitz wrote: > Due to different error propagation, this breaks tests 051 and 087; fix > their output. >=20 > Signed-off-by: Max Reitz > --- > blockdev.c | 92 +++++++++++++++++++++-----------------= -------- > tests/qemu-iotests/051.out | 62 +++++++++++++++---------------- > tests/qemu-iotests/087.out | 8 ++-- > 3 files changed, 77 insertions(+), 85 deletions(-) >=20 > =20 > Testing: -drive file=3DTEST_DIR/t.qcow2,driver=3Dqcow2,format=3Dqcow2 > -QEMU_PROG: -drive file=3DTEST_DIR/t.qcow2,driver=3Dqcow2,format=3Dqcow= 2: could not open disk image TEST_DIR/t.qcow2: Driver specified twice > +QEMU_PROG: -drive file=3DTEST_DIR/t.qcow2,driver=3Dqcow2,format=3Dqcow= 2: Cannot specify both 'driver' and 'format' This one is a nice improvement; I'm glad we added the test in 4/16. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --5V9jJXcDllkKBfmpaHoF0Kcr9TVvrQ9GE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU09EuAAoJEKeha0olJ0Nq/hcH/3gqNdBtRHQCx+P/89+doQmX Dbu3TqoWDBcnirxwkDt+lanIo79AIq2FXNm7j81IbFTLgXBUgllcQcVdMyePEi00 dvyiZZZLmuev56M6SJYlHz9lGvbPt67izJrBCp1gdUuD6Y1QUkBnFyUPdhH5XSF9 T3FfznbsXwgESs/OqyzFgHoAGK5nZVZSKqAlq3Ygm0mCU/b2+kH0Md23KzGsi6cG 69PzzluAMTyWsS80Bwo+oBKD98pf2i17zWP5e6xc5cG+F0jOoaATVkhC4lvpPXO6 FabsLBiPbLbUpPkglVFArXoshoc+6nQF5TWfadn+jcD8+nlm/4R/UidoRvGIdIs= =ronX -----END PGP SIGNATURE----- --5V9jJXcDllkKBfmpaHoF0Kcr9TVvrQ9GE--