From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJTG0-0004LD-V4 for qemu-devel@nongnu.org; Thu, 05 Feb 2015 15:42:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJTFx-0003iN-Pi for qemu-devel@nongnu.org; Thu, 05 Feb 2015 15:42:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49857) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJTFx-0003iF-Hv for qemu-devel@nongnu.org; Thu, 05 Feb 2015 15:42:33 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t15KgV5V004203 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 5 Feb 2015 15:42:31 -0500 Message-ID: <54D3D5B6.3060903@redhat.com> Date: Thu, 05 Feb 2015 13:42:30 -0700 From: Eric Blake MIME-Version: 1.0 References: <1423162705-32065-1-git-send-email-mreitz@redhat.com> <1423162705-32065-7-git-send-email-mreitz@redhat.com> In-Reply-To: <1423162705-32065-7-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jEPD3XLLGOpWrNB73lCC5lS7hJOQ3wMpH" Subject: Re: [Qemu-devel] [PATCH v4 06/16] block/xen: Use blk_new_open() in blk_connect() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jEPD3XLLGOpWrNB73lCC5lS7hJOQ3wMpH Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/05/2015 11:58 AM, Max Reitz wrote: > As part of the required changes, this fixes a bug where specifying an > invalid driver would result in the block layer probing the image format= ; > now it will result in an error, unless "" is specified as the > driver name. Fixing this would require further work on the xen_disk cod= e > which does not seem worth it (at this point and for this patch). With enough hand-waving in the commit message, you can justify practically any partial fix :) Strictly better than pre-patch, and I agree that worrying about the remaining warts is out of scope for this series. >=20 > Signed-off-by: Max Reitz > --- > hw/block/xen_disk.c | 27 +++++++++++---------------- > 1 file changed, 11 insertions(+), 16 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jEPD3XLLGOpWrNB73lCC5lS7hJOQ3wMpH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU09W2AAoJEKeha0olJ0Nqsi0IAIOOUqattBtj0Cem3J1Ql8HO msQUHjWvajl8HUrmzQELCA8wgdDIRS7991k1ycb4jR/siN29Ji7T7uhJnSLzyD0z 8B5PEWjxrXY1gX49wc1pRSfcm26sV3EH4UE+oRfXdjzmF0G1mEEk6y7bE2+DMYIR +72LiSi/8K9XfiwbnGE/X/a/ycp0jJWmiDXneLF45lh0MqsTj+asNaPu7wdI3tt2 /lA17ewRUf0uW1/bQQmLwxz6I3jhKHk/mo7Zj7cYgAfr2gEgbKGrO/tSRhx6rBMv 28dqip+DFcEqIhgogXBUq+4iDIVot1yOjMxbnG208xOgLL3atrBj9j7o1Tf/5Io= =yMZw -----END PGP SIGNATURE----- --jEPD3XLLGOpWrNB73lCC5lS7hJOQ3wMpH--