Re: [Qemu-devel] [PATCH v4 09/16] qemu-img: Use BlockBackend as far as possible

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1505 bytes --]

On 02/05/2015 11:58 AM, Max Reitz wrote:
> Although qemu-img already creates BlockBackends, it does not do accesses
> to the images through them. This patch converts all of the bdrv_* calls
> for which this is currently possible to blk_* calls. Most of the
> remaining calls will probably stay bdrv_* calls because they really do
> operate on the BDS level instead of the BB level.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  qemu-img.c | 82 ++++++++++++++++++++++++++++++--------------------------------
>  1 file changed, 39 insertions(+), 43 deletions(-)
> 
> diff --git a/qemu-img.c b/qemu-img.c
> index 26fb3a1..77fd4e4 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -1010,19 +1010,19 @@ static int64_t sectors_to_process(int64_t total, int64_t from)
>   * Returns 0 in case sectors are filled with 0, 1 if sectors contain non-zero
>   * data and negative value on error.
>   *
> - * @param bs:  Driver used for accessing file
> + * @param blk:  BlockBackend for the image
>   * @param sect_num: Number of first sector to check
>   * @param sect_count: Number of sectors to check

As long as you are touching this, is it worth compressing the double
space into one for consistency with the other lines?

That's minor, and it DOES look a lot nicer without the conversions from
bytes to sectors.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]