From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJTmL-000572-PZ for qemu-devel@nongnu.org; Thu, 05 Feb 2015 16:16:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJTmG-0004wN-Sg for qemu-devel@nongnu.org; Thu, 05 Feb 2015 16:16:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36177) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJTmG-0004wJ-Jj for qemu-devel@nongnu.org; Thu, 05 Feb 2015 16:15:56 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t15LFtHu006034 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 5 Feb 2015 16:15:55 -0500 Message-ID: <54D3DD8A.2050302@redhat.com> Date: Thu, 05 Feb 2015 14:15:54 -0700 From: Eric Blake MIME-Version: 1.0 References: <1423162705-32065-1-git-send-email-mreitz@redhat.com> <1423162705-32065-13-git-send-email-mreitz@redhat.com> In-Reply-To: <1423162705-32065-13-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="40jFSmX7GVp0Blpdk3sBuwXKOqHAECV2h" Subject: Re: [Qemu-devel] [PATCH v4 12/16] qemu-io: Remove "growable" option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --40jFSmX7GVp0Blpdk3sBuwXKOqHAECV2h Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/05/2015 11:58 AM, Max Reitz wrote: > Remove "growable" option from the "open" command and from the qemu-io > command line. qemu-io is about to be converted to BlockBackend which > will make sure that no request exceeds the image size, so the only way > to keep "growable" would be to use BlockBackend if it is not given and > to directly access the BDS if it is. >=20 > qemu-io is a debugging tool, therefore removing a rarely used option > will have only a very small impact, if any. There was only one > qemu-iotest which used the option; since it is not critical, this patch= > just removes it. >=20 > Signed-off-by: Max Reitz > --- > qemu-io.c | 23 +++------------ > tests/qemu-iotests/016 | 73 --------------------------------------= -------- > tests/qemu-iotests/016.out | 23 --------------- > tests/qemu-iotests/group | 2 +- > 4 files changed, 5 insertions(+), 116 deletions(-) > delete mode 100755 tests/qemu-iotests/016 > delete mode 100644 tests/qemu-iotests/016.out >=20 > +++ b/tests/qemu-iotests/group > @@ -22,7 +22,7 @@ > 013 rw auto > 014 rw auto > 015 rw snapshot auto > -016 rw auto quick > +# 016 was removed, do not reuse Works for me. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --40jFSmX7GVp0Blpdk3sBuwXKOqHAECV2h Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU092KAAoJEKeha0olJ0NqzwsIAISPUVV50ALFCRgIxtzePKaU NbmskwfuZkG7AOtFGyCO11QPsgsNjOHSvJ4AGWE1Dhzr1Lw0hgcAOC6O98cNNKpR G/jH0RbmwOnsoF9ILi05crMhgN4Q4Zxf4ivSnRgCXQ5oeBMOq2rwQvoZmgsdftY/ 4+DReO/AqQc/3FXyGCeastcLcj5+rQjD9VEqIF0mKKvYnM6lacqikDbu3QWOyXPS FJGonV+aa6qVzqFHTWTN1ij/a5iYgXEo/7BzdcKVioZjVJ2fxjX7ref9+sh0VuJw wNW3q94ly0EQSqw9x5Buf+yzm999J4E6IQik92RoaZBeuF/V3xkSBqZdkmiwhuQ= =NL4s -----END PGP SIGNATURE----- --40jFSmX7GVp0Blpdk3sBuwXKOqHAECV2h--