From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJUPc-0000so-RZ for qemu-devel@nongnu.org; Thu, 05 Feb 2015 16:56:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJUPZ-0000kn-Mj for qemu-devel@nongnu.org; Thu, 05 Feb 2015 16:56:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56010) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJUPZ-0000kf-F8 for qemu-devel@nongnu.org; Thu, 05 Feb 2015 16:56:33 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t15LuW3Z011349 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 5 Feb 2015 16:56:32 -0500 Message-ID: <54D3E70F.8090203@redhat.com> Date: Thu, 05 Feb 2015 14:56:31 -0700 From: Eric Blake MIME-Version: 1.0 References: <1423162705-32065-1-git-send-email-mreitz@redhat.com> <1423162705-32065-14-git-send-email-mreitz@redhat.com> In-Reply-To: <1423162705-32065-14-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gEWLCMiuKMMu2Cilh0Aj4ljFkX16fvmPs" Subject: Re: [Qemu-devel] [PATCH v4 13/16] qemu-io: Use BlockBackend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gEWLCMiuKMMu2Cilh0Aj4ljFkX16fvmPs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/05/2015 11:58 AM, Max Reitz wrote: > qemu-io should behave like a guest, therefore it should use BlockBacken= d > to access the block layer. >=20 > There are a couple of places where that is infeasible: First, the > bdrv_debug_* functions could theoretically be mirrored in the > BlockBackend, but since these are functions internal to the block layer= , > they should not be visible externally (qemu-io as a test tool is exempt= > from this). >=20 > Second, bdrv_get_info() and bdrv_get_specific_info() work on a single > BDS alone, therefore they should stay BDS-specific. >=20 > Third, bdrv_is_allocated() mainly works on a single BDS as well. Some > data may be passed through from the BDS's file (if sectors which are > apparently allocated in the file are not really allocated there but jus= t > zero). >=20 > Signed-off-by: Max Reitz > --- > hmp.c | 9 ++- > include/qemu-io.h | 4 +- > qemu-io-cmds.c | 237 ++++++++++++++++++++++++++++------------------= -------- > qemu-io.c | 15 ++-- > 4 files changed, 137 insertions(+), 128 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --gEWLCMiuKMMu2Cilh0Aj4ljFkX16fvmPs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU0+cPAAoJEKeha0olJ0NqR9cH/0Xxv6d63xdgh82IINQAH6c1 OH6LdEWI8OOaV8Z6w26x3pbx++ys0o/stI0oQs6y6r56A+P85dUyQjaqA+l0mogi GEd8gaUxaJMODLLNALn6GY7N6y39VQ1ZO0HdobmTe7KHXsKqLLM3q+/OEKqYZkjO VNk1WNQEWpLjc2xorxnJrDbe+B5AvC0H++1lZW7XWbeuITL7Ib151aq1iTIgnuEp OyChnf5Bpylmfp6hHK6CHAk4o58Twu3ZSkjuasJyX+PMQgn+TpssW3MmYl2lvfHr m2NfuZlc+MXW8jagJTPrNqwX4DAU4+ORGJ/x845H6vDgKGqmL+upJI3vdPVgRvs= =Wor0 -----END PGP SIGNATURE----- --gEWLCMiuKMMu2Cilh0Aj4ljFkX16fvmPs--