qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Borislav Petkov <bp@alien8.de>, qemu-devel@nongnu.org
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
	Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH] memsave: Add a space after address in error message
Date: Sun, 08 Feb 2015 11:09:24 +0100	[thread overview]
Message-ID: <54D735D4.8000105@redhat.com> (raw)
In-Reply-To: <1423340992-3156-1-git-send-email-bp@alien8.de>

Cc: qemu-trivial@nongnu.org

On 07/02/2015 21:29, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
> 
> Add the missing space to separate address from "specified".
> 
> Cc: Anthony Liguori <aliguori@amazon.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> ---
>  cpus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cpus.c b/cpus.c
> index 0cdd1d71560b..4fa196d48207 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -1489,7 +1489,7 @@ void qmp_memsave(int64_t addr, int64_t size, const char *filename,
>          if (l > size)
>              l = size;
>          if (cpu_memory_rw_debug(cpu, addr, buf, l, 0) != 0) {
> -            error_setg(errp, "Invalid addr 0x%016" PRIx64 "specified", addr);
> +            error_setg(errp, "Invalid addr 0x%016" PRIx64 " specified", addr);
>              goto exit;
>          }
>          if (fwrite(buf, 1, l, f) != l) {
> 

  reply	other threads:[~2015-02-08 10:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-07 20:29 [Qemu-devel] [PATCH] memsave: Add a space after address in error message Borislav Petkov
2015-02-08 10:09 ` Paolo Bonzini [this message]
2015-02-08 12:14   ` [Qemu-devel] [PATCH] memsave: Improve and disambiguate " Borislav Petkov
2015-02-08 21:46     ` Paolo Bonzini
2015-02-10  9:22       ` Borislav Petkov
2015-02-10 19:06     ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D735D4.8000105@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=bp@alien8.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).