From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKX1I-0002Q3-Te for qemu-devel@nongnu.org; Sun, 08 Feb 2015 13:55:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YKX1F-0007DP-DW for qemu-devel@nongnu.org; Sun, 08 Feb 2015 13:55:48 -0500 Received: from mail-wg0-x232.google.com ([2a00:1450:400c:c00::232]:53269) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKX1F-0007DH-2H for qemu-devel@nongnu.org; Sun, 08 Feb 2015 13:55:45 -0500 Received: by mail-wg0-f50.google.com with SMTP id l18so6914552wgh.9 for ; Sun, 08 Feb 2015 10:55:44 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54D7B12B.7040600@redhat.com> Date: Sun, 08 Feb 2015 19:55:39 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1423257311-1345-1-git-send-email-pbonzini@redhat.com> <1423273144.22865.654.camel@redhat.com> <54D66EE5.50207@redhat.com> <1423416126.22865.668.camel@redhat.com> In-Reply-To: <1423416126.22865.668.camel@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/3] vfio: free data and unmap BARs in instance_finalize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: qemu-devel@nongnu.org On 08/02/2015 18:22, Alex Williamson wrote: > Ok, I went back to 83761b9244ad, applied 3a4dbe6aa934 to get the > object_unparent() fix, then applied this series. Everything seems to > work ok. Then I manually applied and bisected the commits that came in > via d5fbb4c9ed52. I land on 374f2981d1f1 as introducing the segfault in > memory_listener_register(). I guess I was mis-remembering where I did > my testing for the last vfio pull request. My tag was based on ec6f25e, > but I remember that I had to test based on a commit before the RCU > merge. Ouch. memory_listeners needs mutex protection. Paolo