From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKZgE-0006dO-MM for qemu-devel@nongnu.org; Sun, 08 Feb 2015 16:46:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YKZgB-0005en-HL for qemu-devel@nongnu.org; Sun, 08 Feb 2015 16:46:14 -0500 Sender: Paolo Bonzini Message-ID: <54D7D91D.2040505@redhat.com> Date: Sun, 08 Feb 2015 22:46:05 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1423340992-3156-1-git-send-email-bp@alien8.de> <54D735D4.8000105@redhat.com> <20150208121438.GA6290@pd.tnic> In-Reply-To: <20150208121438.GA6290@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] memsave: Improve and disambiguate error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Borislav Petkov Cc: "qemu-trivial@nongnu.org" , qemu-devel@nongnu.org, Anthony Liguori On 08/02/2015 13:14, Borislav Petkov wrote: > On Sun, Feb 08, 2015 at 11:09:24AM +0100, Paolo Bonzini wrote: >> Cc: qemu-trivial@nongnu.org > > Thanks. > > But, there's more b0rked with this error message so you might wanna take > the patch below instead. > > Btw, what are the vim settings when doing patches for qemu, this must be > documented somewhere as coding style differs significantly from that of > the kernel? I use ":set shiftwidth=4 expandtab" and c-indent mode. Quick googling for "vim four spaces" suggests the following alternatives: * ":set tabstop=8 expandtab shiftwidth=4 softtabstop=4" * "set tabstop=8 softtabstop=0 expandtab shiftwidth=4 smarttab". Paolo