From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40249)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1YKiIk-0005Rp-Mj
	for qemu-devel@nongnu.org; Mon, 09 Feb 2015 01:58:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1YKiIh-0002M3-HI
	for qemu-devel@nongnu.org; Mon, 09 Feb 2015 01:58:34 -0500
Received: from mga02.intel.com ([134.134.136.20]:31596)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1YKiIh-0002Lv-Bg
	for qemu-devel@nongnu.org; Mon, 09 Feb 2015 01:58:31 -0500
Message-ID: <54D85A91.1010403@intel.com>
Date: Mon, 09 Feb 2015 14:58:25 +0800
From: "Chen, Tiejun" <tiejun.chen@intel.com>
MIME-Version: 1.0
References: <1423201286-16503-1-git-send-email-tiejun.chen@intel.com>
	<20150206162827.GL18729@stefanha-thinkpad.redhat.com>
In-Reply-To: <20150206162827.GL18729@stefanha-thinkpad.redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [v2][RFC][PATCH] virtio: uniform virtio device IDs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: borntraeger@de.ibm.com, mst@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com, aliguori@amazon.com, amit.shah@redhat.com

On 2015/2/7 0:28, Stefan Hajnoczi wrote:
> On Fri, Feb 06, 2015 at 01:41:26PM +0800, Tiejun Chen wrote:
>> Actually we define these device IDs in virtio standard, so
>> we'd better put them into one common place to manage conveniently.
>> Here I also add VIRTIO_ID_RESERVE according to virtio spec.
>>
>> Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
>> ---
>>   hw/9pfs/virtio-9p.h                |  2 --
>>   include/hw/virtio/virtio-balloon.h |  3 ---
>>   include/hw/virtio/virtio-blk.h     |  3 ---
>>   include/hw/virtio/virtio-rng.h     |  3 ---
>>   include/hw/virtio/virtio-scsi.h    |  3 ---
>>   include/hw/virtio/virtio-serial.h  |  3 ---
>>   include/hw/virtio/virtio.h         | 16 ++++++++++++++++
>>   pc-bios/s390-ccw/virtio.h          |  8 +-------
>>   8 files changed, 17 insertions(+), 24 deletions(-)
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Thanks for you review.

Just a little change will be introduced in next revision.

Tiejun