From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44521)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1YKlN1-0005Q4-Ug
	for qemu-devel@nongnu.org; Mon, 09 Feb 2015 05:15:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1YKlMw-0004Dd-Vo
	for qemu-devel@nongnu.org; Mon, 09 Feb 2015 05:15:11 -0500
Received: from lhrrgout.huawei.com ([194.213.3.17]:16667)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1YKlMw-0003yO-Np
	for qemu-devel@nongnu.org; Mon, 09 Feb 2015 05:15:06 -0500
Message-ID: <54D8889D.1090906@huawei.com>
Date: Mon, 9 Feb 2015 11:14:53 +0100
From: Claudio Fontana <claudio.fontana@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] --disable-vnc broken?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Hello,

is some #ifdef CONFIG_VNC missing in the latest vnc changes in mainline QEMU?

I ask because configuring with --disable-vnc and then building now gets me:

../qmp-marshal.o: In function `qmp_marshal_input_query_vnc_servers':
qemu/qmp-marshal.c:2899: undefined reference to `qmp_query_vnc_servers'

while before it was working fine.

Configuring without --disable-vnc and then building works.

I bisected this and got the following.

Thanks,

Claudio

df887684603a4b3b0c623090a6b419dc70f22c32 is the first bad commit
commit df887684603a4b3b0c623090a6b419dc70f22c32
Author: Gerd Hoffmann <kraxel@redhat.com>
Date:   Wed Dec 17 15:49:44 2014 +0100

    monitor: add query-vnc-servers command

    Add new query vnc qmp command, for the lack of better ideas just name it
    "query-vnc-servers".  Changes over query-vnc:

     * It returns a list of vnc servers, so multiple vnc server instances
       are covered.
     * Each vnc server returns a list of server sockets.  Followup patch
       will use that to also report websockets.  In case we add support for
       multiple server sockets server sockets (to better support ipv4+ipv6
       dualstack) we can add them to the list too.

    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>