From: Paolo Bonzini <pbonzini@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/3] nbd: Drop BDS backpointer
Date: Mon, 09 Feb 2015 13:33:16 +0100 [thread overview]
Message-ID: <54D8A90C.10400@redhat.com> (raw)
In-Reply-To: <1423256778-3340-2-git-send-email-mreitz@redhat.com>
On 06/02/2015 22:06, Max Reitz wrote:
> @@ -889,7 +889,7 @@ void nbd_client_put(NBDClient *client)
> }
> }
>
> -void nbd_client_close(NBDClient *client)
> +static void client_close(NBDClient *client)
> {
> if (client->closing) {
> return;
Probably NBDClient should be renamed to NBDServerSession. Can be done
on top.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
next prev parent reply other threads:[~2015-02-09 12:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 21:06 [Qemu-devel] [PATCH v2 0/3] nbd: Drop BDS backpointer Max Reitz
2015-02-06 21:06 ` [Qemu-devel] [PATCH v2 1/3] " Max Reitz
2015-02-09 12:33 ` Paolo Bonzini [this message]
2015-02-06 21:06 ` [Qemu-devel] [PATCH v2 2/3] iotests: Add "wait" functionality to _cleanup_qemu Max Reitz
2015-02-09 15:01 ` Stefan Hajnoczi
2015-02-09 15:37 ` Max Reitz
2015-02-09 17:49 ` Stefan Hajnoczi
2015-02-06 21:06 ` [Qemu-devel] [PATCH v2 3/3] iotests: Add test for drive-mirror with NBD target Max Reitz
2015-02-09 17:54 ` [Qemu-devel] [PATCH v2 0/3] nbd: Drop BDS backpointer Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D8A90C.10400@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).