Re: [Qemu-devel] [PATCH] checkpatch: port fix from kernel "## is not a valid modifier"

[Christian Borntraeger <borntraeger@de.ibm.com>]

Am 09.02.2015 um 15:31 schrieb Paolo Bonzini:
> 
> 
> On 09/02/2015 13:18, Christian Borntraeger wrote:
>> From: Andy Whitcroft <apw@canonical.com>
>>
>> checkpatch currently loops on fpu/softfloat.c
>> Turns out this is fixed in the Linux version of checkpatch.
>>
>> So this is a port of Andy Whitcrofts fix from Linux,
>> Original commit was commit 89a883530fe7 ("checkpatch: ## is not a
>> valid modifier")
> 
> I think you need to send it as a toplevel patch for Peter to pick it up.

What do you mean? This patch is on top of qemu/master - if I dont messed up.

Christian
> 
> Paolo
> 
>> Cc: Andy Whitcroft <apw@canonical.com>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>>  scripts/checkpatch.pl | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index 5df61f9..8635f4c 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -1061,7 +1061,9 @@ sub possible {
>>  			case|
>>  			else|
>>  			asm|__asm__|
>> -			do
>> +			do|
>> +			\#|
>> +			\#\#|
>>  		)(?:\s|$)|
>>  		^(?:typedef|struct|enum)\b
>>  	    )}x;
>>
>