From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58604)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1YKpwZ-0000Ev-7k
	for qemu-devel@nongnu.org; Mon, 09 Feb 2015 10:08:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1YKpwV-0003AO-GK
	for qemu-devel@nongnu.org; Mon, 09 Feb 2015 10:08:11 -0500
Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:58880)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1YKpwV-00038f-6b
	for qemu-devel@nongnu.org; Mon, 09 Feb 2015 10:08:07 -0500
Received: from /spool/local
	by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Mon, 9 Feb 2015 15:08:04 -0000
Received: from b06cxnps4074.portsmouth.uk.ibm.com
	(d06relay11.portsmouth.uk.ibm.com [9.149.109.196])
	by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id B85781B0806B
	for <qemu-devel@nongnu.org>; Mon,  9 Feb 2015 15:08:11 +0000 (GMT)
Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com
	[9.149.37.213])
	by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id t19F825p1900968
	for <qemu-devel@nongnu.org>; Mon, 9 Feb 2015 15:08:02 GMT
Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id t19F81Aa014966
	for <qemu-devel@nongnu.org>; Mon, 9 Feb 2015 08:08:02 -0700
Message-ID: <54D8CD51.5080308@de.ibm.com>
Date: Mon, 09 Feb 2015 16:08:01 +0100
From: Christian Borntraeger <borntraeger@de.ibm.com>
MIME-Version: 1.0
References: <CAFEAcA9dvehzeL1T+BT3N+_GJtGoL4ig_opv7rVT-0eJekLAvg@mail.gmail.com>
	<1423484293-46903-1-git-send-email-borntraeger@de.ibm.com>
	<54D8C4DA.4080403@redhat.com>
In-Reply-To: <54D8C4DA.4080403@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] checkpatch: port fix from kernel "## is
	not a valid modifier"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Peter Maydell <peter.maydell@linaro.org>
Cc: Andy Whitcroft <apw@canonical.com>, qemu-devel <qemu-devel@nongnu.org>, dgilbert@redhat.com

Am 09.02.2015 um 15:31 schrieb Paolo Bonzini:
> 
> 
> On 09/02/2015 13:18, Christian Borntraeger wrote:
>> From: Andy Whitcroft <apw@canonical.com>
>>
>> checkpatch currently loops on fpu/softfloat.c
>> Turns out this is fixed in the Linux version of checkpatch.
>>
>> So this is a port of Andy Whitcrofts fix from Linux,
>> Original commit was commit 89a883530fe7 ("checkpatch: ## is not a
>> valid modifier")
> 
> I think you need to send it as a toplevel patch for Peter to pick it up.

What do you mean? This patch is on top of qemu/master - if I dont messed up.

Christian
> 
> Paolo
> 
>> Cc: Andy Whitcroft <apw@canonical.com>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>>  scripts/checkpatch.pl | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index 5df61f9..8635f4c 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -1061,7 +1061,9 @@ sub possible {
>>  			case|
>>  			else|
>>  			asm|__asm__|
>> -			do
>> +			do|
>> +			\#|
>> +			\#\#|
>>  		)(?:\s|$)|
>>  		^(?:typedef|struct|enum)\b
>>  	    )}x;
>>
>