From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKszf-0002fG-O1 for qemu-devel@nongnu.org; Mon, 09 Feb 2015 13:23:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YKsza-00060m-Px for qemu-devel@nongnu.org; Mon, 09 Feb 2015 13:23:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37508) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKsza-00060W-HC for qemu-devel@nongnu.org; Mon, 09 Feb 2015 13:23:30 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t19INTsX015674 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 9 Feb 2015 13:23:30 -0500 Message-ID: <54D8FB20.1070802@redhat.com> Date: Mon, 09 Feb 2015 11:23:28 -0700 From: Eric Blake MIME-Version: 1.0 References: <1423501897-30410-1-git-send-email-mreitz@redhat.com> <1423501897-30410-4-git-send-email-mreitz@redhat.com> In-Reply-To: <1423501897-30410-4-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8mIxnGOr2tDxUgQ6Gr8RaubFrFOruRKb6" Subject: Re: [Qemu-devel] [PATCH v2 03/37] hw/block/fdc: Implement tray status List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , John Snow , Markus Armbruster , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8mIxnGOr2tDxUgQ6Gr8RaubFrFOruRKb6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/09/2015 10:11 AM, Max Reitz wrote: > The tray of an FDD is open iff there is no medium inserted (there are > only two states for an FDD: "medium inserted" or "no medium inserted").= >=20 > This results in the tray being reported as open if qemu has been starte= d > with the default floppy drive, which breaks some tests. Fix them. >=20 > Signed-off-by: Max Reitz > --- > hw/block/fdc.c | 20 +++++++++++++--- > tests/fdc-test.c | 4 +--- > tests/qemu-iotests/067.out | 60 +++++++-------------------------------= -------- > tests/qemu-iotests/071.out | 2 -- > tests/qemu-iotests/081.out | 1 - > tests/qemu-iotests/087.out | 6 ----- > 6 files changed, 26 insertions(+), 67 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --8mIxnGOr2tDxUgQ6Gr8RaubFrFOruRKb6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU2PsgAAoJEKeha0olJ0NqUhsH/3nJLEbQjYvWzpRGf7Eqo46B 4/frCfcy22yNVilKjN6lb/pA77EDFGsIMgrYyxiPE+CMiPfiQv3AjQRvsa6cyb4C I5CFmJR9jx9VqqU/UXp0mlAJFUyRQzY3Nm9VeKdVk6Ly0z6kjgTqCf2AI2hEbTZM jnWBOWOXnWqbnPSTJ63bpLi3km9P3sszfreubPHXJlbqR3Kpe3Lz8ooXKd46DmZq Kyeh5aZbYrtanxb2EUaVEHeuV64zVQ+rutFguA4u8A+QfjM8JVGlUV/KIdd3ovRD ZqhSpd2QvZ16voZlTg442a/qiU4VttM6ncb2MHFOgjc/ABqNX7SCEwxpoeFPgyU= =6UUQ -----END PGP SIGNATURE----- --8mIxnGOr2tDxUgQ6Gr8RaubFrFOruRKb6--