From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKtst-0002Ph-1f for qemu-devel@nongnu.org; Mon, 09 Feb 2015 14:20:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YKtsn-00086i-IW for qemu-devel@nongnu.org; Mon, 09 Feb 2015 14:20:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKtsm-00085v-TO for qemu-devel@nongnu.org; Mon, 09 Feb 2015 14:20:33 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t19JKVWX011894 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 9 Feb 2015 14:20:31 -0500 Message-ID: <54D9087E.9020909@redhat.com> Date: Mon, 09 Feb 2015 12:20:30 -0700 From: Eric Blake MIME-Version: 1.0 References: <1423501897-30410-1-git-send-email-mreitz@redhat.com> <1423501897-30410-12-git-send-email-mreitz@redhat.com> In-Reply-To: <1423501897-30410-12-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lnF6igbqqgCAATUe51temC3N4J346Wufj" Subject: Re: [Qemu-devel] [PATCH v2 11/37] block: Remove wr_highest_sector from BlockAcctStats List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , John Snow , Markus Armbruster , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lnF6igbqqgCAATUe51temC3N4J346Wufj Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/09/2015 10:11 AM, Max Reitz wrote: > BlockAcctStats contains statistics about the data transferred from and > to the device; wr_highest_sector does not fit in with the rest. >=20 > Furthermore, those statistics are supposed to be specific for a certain= > device and not necessarily for a BDS (see the comment above > bdrv_get_stats()); on the other hand, wr_highest_sector may be a rather= > important information to know for each BDS. When BlockAcctStats is > finally removed from the BDS, we will want to keep wr_highest_sector in= > the BDS. >=20 > Finally, wr_highest_sector is renamed to wr_highest_offset and given th= e > appropriate meaning. Externally, it is represented as an offset so ther= e > is no point in doing something different internally. Its definition is > changed to match that in qapi/block-core.json which is "the offset afte= r > the greatest byte written to". Doing so should not cause any harm since= > if external programs tried to calculate the volume usage by > (wr_highest_offset + 512) / volume_size, after this patch they will jus= t > assume the volume to be full slightly earlier than before. >=20 > Signed-off-by: Max Reitz > --- > block.c | 4 +++- > block/accounting.c | 8 -------- > block/qapi.c | 4 ++-- > include/block/accounting.h | 3 --- > include/block/block_int.h | 3 +++ > qmp-commands.hx | 4 ++-- > 6 files changed, 10 insertions(+), 16 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --lnF6igbqqgCAATUe51temC3N4J346Wufj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU2Qh+AAoJEKeha0olJ0Nq/wEIAKD6H+rPGP/Yot1GcR+KJQ0Z 7LMdO58+DwyznBwl69BFuqrAgNhKHABEoHEiWmr8fCGLUBH54v3Sj4avkpSvRqi/ EjO9WjOl3rkOMCzPRmOWqxcJcFVbOy0jsuES58QH93vH0WynlwcsAZfL5oKoTVej iJ3GKdX1sCRRhAf5EdgOXx8/FeU8Hw7xhNL0GXAOvu5+fvP1x0CzjXtVoiww57Fw jHP8BeY7vofcSbNSyypP49dZC9cuSVJ+7oN/hWDS05KE8sfUOT7W1Z5klO2IFRN2 bXoMVNxSNPqXLZhrUSL2Ot7v5hz5fHSsf6sBwWyPFfxWgkX58/eotOy2cJLDF2Q= =l/87 -----END PGP SIGNATURE----- --lnF6igbqqgCAATUe51temC3N4J346Wufj--