From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKvwK-0000xg-Tj for qemu-devel@nongnu.org; Mon, 09 Feb 2015 16:32:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YKvwC-00078m-28 for qemu-devel@nongnu.org; Mon, 09 Feb 2015 16:32:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45788) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKvwB-00078Y-Pj for qemu-devel@nongnu.org; Mon, 09 Feb 2015 16:32:11 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t19LWAn2008789 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 9 Feb 2015 16:32:11 -0500 Message-ID: <54D92758.2080406@redhat.com> Date: Mon, 09 Feb 2015 14:32:08 -0700 From: Eric Blake MIME-Version: 1.0 References: <1423501897-30410-1-git-send-email-mreitz@redhat.com> <1423501897-30410-22-git-send-email-mreitz@redhat.com> In-Reply-To: <1423501897-30410-22-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="evwti7wiODIqlEJRpLvIp452uF04QcTIK" Subject: Re: [Qemu-devel] [PATCH v2 21/37] blockdev: Do not create BDS for empty drive List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , John Snow , Markus Armbruster , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --evwti7wiODIqlEJRpLvIp452uF04QcTIK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/09/2015 10:11 AM, Max Reitz wrote: > Do not use "rudimentary" BDSs for empty drives any longer (for > freshly created drives). >=20 > With this change, bdrv_close_all() has no effect on empty drives (whose= > media were not changed) any longer. This breaks some test outputs, fix > them. >=20 > After a follow-up patch, empty drives will generally use a NULL BDS, no= t > only the freshly created drives. >=20 > Signed-off-by: Max Reitz > --- > blockdev.c | 68 ++++++++++++++++++++++++++------------= -------- > tests/qemu-iotests/067.out | 44 ------------------------------ > tests/qemu-iotests/071.out | 2 -- > tests/qemu-iotests/081.out | 1 - > tests/qemu-iotests/087.out | 6 ---- > 5 files changed, 38 insertions(+), 83 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --evwti7wiODIqlEJRpLvIp452uF04QcTIK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU2SdYAAoJEKeha0olJ0NqLE0H/3ZeZObjyRSrSi1p3FrXKAAf 2rQFCjf9VZbrXbRs7VTSOTZuBPOCqJecmChj8ux+3/tQZJkOvhlzwkAScfZWooWh qC2vII3il71wLdy8ufwVjoQAnokPRlBc7c159crLg2pz5+YDn/34kFS93LWTV/lY 4vk9zRfsiwuBKuYBTLoCTYYVABIxzQr+gxLWumgJdjOAWHbpUHXcGyTh3DqZqWN0 jepCTHw0uP3lRULx3koAdSFL1qLbswe15bSB/JjJi1QLxQK+FrfQTheWhTdfNvEt mq5e72WIC5gx7yRoVY2VvcPZ4yt+TYHis0/dozicGTjMlphLy+lhLuxyZELV9dA= =bQqp -----END PGP SIGNATURE----- --evwti7wiODIqlEJRpLvIp452uF04QcTIK--