From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YL4id-0003No-QJ for qemu-devel@nongnu.org; Tue, 10 Feb 2015 01:54:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YL4iZ-0000ZM-0Q for qemu-devel@nongnu.org; Tue, 10 Feb 2015 01:54:47 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:58027) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YL4iY-0000Yz-CN for qemu-devel@nongnu.org; Tue, 10 Feb 2015 01:54:42 -0500 Message-ID: <54D9AB19.7030008@huawei.com> Date: Tue, 10 Feb 2015 14:54:17 +0800 From: Linhaifeng MIME-Version: 1.0 References: <1423547293-8448-1-git-send-email-haifeng.lin@huawei.com> <1423547293-8448-2-git-send-email-haifeng.lin@huawei.com> <54D9A6BF.1050703@huawei.com> In-Reply-To: <54D9A6BF.1050703@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 2/2] vhost-user: add reply for set_mem_table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gonglei , qemu-devel@nongnu.org Cc: mst@redhat.com On 2015/2/10 14:35, Gonglei wrote: > On 2015/2/10 13:48, linhaifeng wrote: >> From: Linhaifeng >> >> If u64 is not 0 we should return -1 to tell qemu not going on. >> >> Remove some unnecessary '\n' in error_report. > Hi, haifeng: > > You'd better split a single patch to do this work, > and using '--cover' argument for patch series when git format-patch . :) > good idea! > Regards, > -Gonglei >> >> Signed-off-by: Linhaifeng >> --- >> hw/virtio/vhost-user.c | 33 ++++++++++++++++++++++----------- >> 1 file changed, 22 insertions(+), 11 deletions(-) > > > > . > -- Regards, Haifeng