From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42851)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1YL5qx-0006Ui-4j
	for qemu-devel@nongnu.org; Tue, 10 Feb 2015 03:07:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1YL5qs-00018y-3e
	for qemu-devel@nongnu.org; Tue, 10 Feb 2015 03:07:27 -0500
Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:56991)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1YL5qr-00018n-Pp
	for qemu-devel@nongnu.org; Tue, 10 Feb 2015 03:07:22 -0500
Received: from /spool/local
	by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Tue, 10 Feb 2015 08:07:20 -0000
Received: from b06cxnps4074.portsmouth.uk.ibm.com
	(d06relay11.portsmouth.uk.ibm.com [9.149.109.196])
	by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id C69EA1B0805F
	for <qemu-devel@nongnu.org>; Tue, 10 Feb 2015 08:07:27 +0000 (GMT)
Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com
	[9.149.37.248])
	by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id t1A87IVD9896366
	for <qemu-devel@nongnu.org>; Tue, 10 Feb 2015 08:07:18 GMT
Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id t1A87HbW000877
	for <qemu-devel@nongnu.org>; Tue, 10 Feb 2015 03:07:18 -0500
Message-ID: <54D9BC34.7060500@de.ibm.com>
Date: Tue, 10 Feb 2015 09:07:16 +0100
From: Christian Borntraeger <borntraeger@de.ibm.com>
MIME-Version: 1.0
References: <1423510988-48508-1-git-send-email-borntraeger@de.ibm.com>
	<CAFEAcA_phUkjBJOg5hnd7RCR29xOWkBFVhH094ipn6=EBbc6qQ@mail.gmail.com>
In-Reply-To: <CAFEAcA_phUkjBJOg5hnd7RCR29xOWkBFVhH094ipn6=EBbc6qQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] checkpatch: port fix from kernel "## is
	not a valid modifier"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Andy Whitcroft <apw@canonical.com>, qemu-devel <qemu-devel@nongnu.org>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Am 09.02.2015 um 23:54 schrieb Peter Maydell:
> On 9 February 2015 at 19:43, Christian Borntraeger
> <borntraeger@de.ibm.com> wrote:
>> From: Andy Whitcroft <apw@canonical.com>
>>
>> checkpatch currently loops on fpu/softfloat.c
>> Turns out this is fixed in the Linux version of checkpatch.
>>
>> So this is a port of Andy Whitcrofts fix from Linux,
>> Original commit was commit 89a883530fe7 ("checkpatch: ## is not a
>> valid modifier")
>>
>> Cc: Andy Whitcroft <apw@canonical.com>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>>  scripts/checkpatch.pl | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index 5df61f9..8635f4c 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -1061,7 +1061,9 @@ sub possible {
>>                         case|
>>                         else|
>>                         asm|__asm__|
>> -                       do
>> +                       do|
>> +                       \#|
>> +                       \#\#|
> 
> Are you sure this line should end with a '|', given it's the
> last item in the alternation ?

Good question - dont know. But the kernel version looks the same.