From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YL66O-0005dQ-S4 for qemu-devel@nongnu.org; Tue, 10 Feb 2015 03:23:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YL66O-00064f-6R for qemu-devel@nongnu.org; Tue, 10 Feb 2015 03:23:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38284) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YL66N-00064T-Tq for qemu-devel@nongnu.org; Tue, 10 Feb 2015 03:23:24 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1A8NN6V014076 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 10 Feb 2015 03:23:23 -0500 Message-ID: <54D9BFF3.1020700@redhat.com> Date: Tue, 10 Feb 2015 09:23:15 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1423507124-29809-1-git-send-email-mreitz@redhat.com> In-Reply-To: <1423507124-29809-1-git-send-email-mreitz@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 00/22] block: Rework bdrv_close_all() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi On 09/02/2015 19:38, Max Reitz wrote: > Currently, bdrv_close_all() force-closes all BDSs with a BlockBackend, > which can lead to data corruption (see the iotest added in the final > patch of this series) and is most certainly very ugly. > > This series reworks bdrv_close_all() to notify all owners of a > BlockBackend that they should release their reference (and additionally > the monitor releases all its references to BB-less BDSs). This way, > force-closing becomes unnecessary. The NBD parts look good. Paolo