From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Michael Tokarev <mjt@tls.msk.ru>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 14/46] cpu-exec: drop dead assignment
Date: Tue, 10 Feb 2015 10:19:56 +0100 [thread overview]
Message-ID: <54D9CD3C.5050307@redhat.com> (raw)
In-Reply-To: <CAFEAcA-wWs1sTvVwOTi6Q0rXAXOOO5kWMAaZ0se5asu97B4S5Q@mail.gmail.com>
On 10/02/2015 10:15, Peter Maydell wrote:
> > - tb = (TranslationBlock *)(next_tb & ~TB_EXIT_MASK);
> > next_tb = 0;
> > break;
> > case TB_EXIT_ICOUNT_EXPIRED:
>
> True, I guess, but presumably this means we're doing unnecessary
> work in the next time round the loop re-finding the tb which we
> already had...
This is the TB_EXIT_REQUESTED case though: once the iothread runs who
knows what happens. You might get an interrupt or a system reset that
diverts execution away from tb.
Paolo
next prev parent reply other threads:[~2015-02-10 9:20 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 6:33 [Qemu-devel] [PULL 00/46] Trivial patches for 2015-02-10 Michael Tokarev
2015-02-10 6:33 ` [Qemu-devel] [PULL 01/46] target-mips: Clean up switch fall through after commit fecd264 Michael Tokarev
2015-02-10 6:33 ` [Qemu-devel] [PULL 02/46] fw_cfg: fix typos in comments: patch -> path Michael Tokarev
2015-02-10 6:33 ` [Qemu-devel] [PULL 03/46] Add tracing to xenfb Michael Tokarev
2015-02-10 6:33 ` [Qemu-devel] [PULL 04/46] Add trace to ps2.c Michael Tokarev
2015-02-10 6:33 ` [Qemu-devel] [PULL 05/46] Add/convert trace calls in pcnet-pci.c Michael Tokarev
2015-02-10 6:33 ` [Qemu-devel] [PULL 06/46] Convert some debugging printfs to trace calls in pcnet.c Michael Tokarev
2015-02-10 6:33 ` [Qemu-devel] [PULL 07/46] vl: Fix bogus error message for implied mon ID clashing Michael Tokarev
2015-02-10 6:33 ` [Qemu-devel] [PULL 08/46] virtfs-proxy-helper: Fix possible socket leak Michael Tokarev
2015-02-10 6:33 ` [Qemu-devel] [PULL 09/46] linux-user/syscall.c: lock_iovec: unlock vec[i] in failure processing code block Michael Tokarev
2015-02-10 6:33 ` [Qemu-devel] [PULL 10/46] linux-user/syscall.c: Fix typo issue for using target_vec[i].iov_len instead of target_vec[i].iov_base Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 11/46] linux-user/main.c: Use TARGET_SIG* instead of SIG* Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 12/46] linux-user/syscall.c: do_ioctl_dm: Need to call unlock_user() before going to failure return in default case Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 13/46] qemu-log: Correct help text of 'log cpu_reset' Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 14/46] cpu-exec: drop dead assignment Michael Tokarev
2015-02-10 9:15 ` Peter Maydell
2015-02-10 9:19 ` Paolo Bonzini [this message]
2015-02-10 6:34 ` [Qemu-devel] [PULL 15/46] cpu-exec: simplify icount code Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 16/46] qemu-sockets: improve error reporting in unix_listen_opts Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 17/46] aes: remove a dead return statement Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 18/46] vl.c: fix memory leak spotted by valgrind Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 19/46] qemu-sockets: Fix buffer overflow in inet_parse() Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 20/46] linux-user: wrong TARGET_SI_PAD_SIZE value for some targets Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 21/46] libcacard: stop linking against every single 3rd party library Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 22/46] qemu-option: Replace pointless use of g_malloc0() by g_malloc() Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 23/46] qemu-option: Pair g_malloc() with g_free(), not free() Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 24/46] spapr_vio: " Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 25/46] usb: " Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 26/46] util/uri: uri_new() can't fail, drop dead error handling Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 27/46] util/uri: realloc2n() " Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 28/46] util/uri: URI member path can be null, compare more carfully Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 29/46] QJSON: fix typo in author's email address Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 30/46] Fix name error in migration stream analyzation script Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 31/46] onenand: g_malloc() can't fail, bury dead error handling Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 32/46] rtl8139: " Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 33/46] kvm: " Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 34/46] rdma: g_malloc0() " Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 35/46] vnc: g_realloc() " Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 36/46] translate-all: Use g_try_malloc() for dynamic translator buffer Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 37/46] disas/cris: Fix warning caused by missing 'static' attribute Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 38/46] disas/sh4: " Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 39/46] migration: Fix warning caused by missing declaration of vmstate_dummy Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 40/46] migration: Fix warnings caused by missing 'static' attribute Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 41/46] moxie: Fix warning caused by missing include statement Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 42/46] serial: Fix warnings caused by missing 'static' attribute Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 43/46] spice: Add " Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 44/46] stubs: Fix warning caused by missing include statement Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 45/46] vga: Fix warning caused by missing 'static' attribute Michael Tokarev
2015-02-10 6:34 ` [Qemu-devel] [PULL 46/46] virtio: " Michael Tokarev
2015-02-10 7:14 ` [Qemu-devel] [PULL 00/46] Trivial patches for 2015-02-10 Peter Maydell
2015-02-10 7:29 ` Michael Tokarev
2015-02-10 10:42 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D9CD3C.5050307@redhat.com \
--to=pbonzini@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).